Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some links still point to the main branch in the spec repo #549

Closed
patrickhousley opened this issue Nov 21, 2023 · 2 comments · Fixed by #556
Closed

Some links still point to the main branch in the spec repo #549

patrickhousley opened this issue Nov 21, 2023 · 2 comments · Fixed by #556
Assignees
Labels
bug Something isn't working

Comments

@patrickhousley
Copy link
Contributor

In a recent change to the events conventions, discussions were had to update a link from pointing to a specific version/branch of the semantic conventions repository to point to the main branch instead. In discussion on the client-side SIG, we agreed that the link should point to the main branch. While that PR was updated, this repository has many other links that follow suite and need to be updated to point to main instead of a specific version.

Relavent Discussions:
#473 (comment)
#473 (comment)

@patrickhousley
Copy link
Contributor Author

Links are in fact supposed to point to a specific version of the semantic conventions repository. There are a handful of links in the repo that do not meet that requirement.

@joaopgrassi joaopgrassi changed the title Update links to specifications to main branch Some links still point to the main branch in the spec repo Nov 23, 2023
@joaopgrassi
Copy link
Member

joaopgrassi commented Nov 23, 2023

Thanks, I've sent a PR to fix the wrong links.

@joaopgrassi joaopgrassi added the bug Something isn't working label Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants