From 632151e2e983db8403ea6a34849cd97e7209c1f8 Mon Sep 17 00:00:00 2001 From: Trask Stalnaker Date: Tue, 31 Oct 2023 08:22:14 -0700 Subject: [PATCH] Remove outdated http.request.header.host guidance --- CHANGELOG.md | 2 ++ docs/http/http-spans.md | 4 ---- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 50adef6b59..d6f40d3fa0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -48,6 +48,8 @@ release. ([#459](https://github.com/open-telemetry/semantic-conventions/pull/459)) - Make `client.address` sampling relevant on HTTP server spans. ([#469](https://github.com/open-telemetry/semantic-conventions/pull/469)) +- Remove outdated `http.request.header.host` guidance + ([#479](https://github.com/open-telemetry/semantic-conventions/pull/479)) ### Features diff --git a/docs/http/http-spans.md b/docs/http/http-spans.md index 6e2ba2f685..fda888db0d 100644 --- a/docs/http/http-spans.md +++ b/docs/http/http-spans.md @@ -254,8 +254,6 @@ Following attributes MUST be provided **at span creation time** (when provided a * [`url.full`](../attributes-registry/url.md) -Note that in some cases host and port identifiers in the `Host` header might be different from the `server.address` and `server.port`, in this case instrumentation MAY populate `Host` header on `http.request.header.host` attribute even if it's not enabled by user. - ### HTTP client span duration There are some minimal constraints that SHOULD be honored: @@ -378,8 +376,6 @@ Following attributes MUST be provided **at span creation time** (when provided a `http.route` MUST be provided at span creation time if and only if it's already available. If it becomes available after span starts, instrumentation MUST populate it anytime before span ends. -Note that in some cases host and port identifiers in the `Host` header might be different from the `server.address` and `server.port`, in this case instrumentation MAY populate `Host` header on `http.request.header.host` attribute even if it's not enabled by user. - ## Examples ### HTTP client-server example