From a9791c077cd6d242a7a9e9e918b308c04b341572 Mon Sep 17 00:00:00 2001 From: Braydon Kains Date: Thu, 16 Nov 2023 09:45:57 -0500 Subject: [PATCH 01/15] Created network and disk io.direction attributes --- model/metrics/system-metrics.yaml | 55 ++++++++++++++++++------------- 1 file changed, 33 insertions(+), 22 deletions(-) diff --git a/model/metrics/system-metrics.yaml b/model/metrics/system-metrics.yaml index d3c761b0b9..44118d45c7 100644 --- a/model/metrics/system-metrics.yaml +++ b/model/metrics/system-metrics.yaml @@ -213,12 +213,14 @@ groups: - ref: system.paging.direction # system.disk.* metrics and attribute group - - id: attributes.system.disk - prefix: system.disk + + # General disk attributes + - id: attributes.disk + prefix: disk type: attribute_group - brief: "Describes System Disk metric attributes" + brief: "Describes attributes used in disk-related metrics" attributes: - - id: direction + - id: io.direction type: allow_custom_values: false members: @@ -226,7 +228,7 @@ groups: value: 'read' - id: write value: 'write' - brief: "The disk operation direction" + brief: "The disk IO operation direction" examples: ["read"] - id: metric.system.disk.io @@ -237,7 +239,7 @@ groups: unit: "By" attributes: - ref: system.device - - ref: system.disk.direction + - ref: disk.io.direction - id: metric.system.disk.operations type: metric @@ -247,7 +249,7 @@ groups: unit: "{operation}" attributes: - ref: system.device - - ref: system.disk.direction + - ref: disk.io.direction - id: metric.system.disk.io_time type: metric @@ -278,7 +280,7 @@ groups: - Windows: "Avg. Disk sec/Read" perf counter multiplied by "Disk Reads/sec" perf counter (similar for Writes) attributes: - ref: system.device - - ref: system.disk.direction + - ref: disk.io.direction - id: metric.system.disk.merged type: metric @@ -288,7 +290,7 @@ groups: unit: "{operation}" attributes: - ref: system.device - - ref: system.disk.direction + - ref: disk.io.direction # system.filesystem.* metrics and attribute group - id: attributes.system.filesystem @@ -361,22 +363,31 @@ groups: - ref: system.filesystem.mode - ref: system.filesystem.mountpoint - # system.network.* metrics and attribute group - - id: attributes.system.network - prefix: system.network + # system.network.* metrics and attribute group + + # General network attributes + - id: attributes.network + prefix: network type: attribute_group - brief: "Describes Network metric attributes" + brief: "Describes attributes used in network-related metrics" attributes: - - id: direction + - id: io.direction type: allow_custom_values: false members: - - id: transmit - value: 'transmit' + - id: send + value: 'send' - id: receive value: 'receive' - brief: "" - examples: ["transmit"] + brief: "The network IO operation direction" + examples: ["send"] + + # System-specific network attributes + - id: attributes.system.network + prefix: system.network + type: attribute_group + brief: "Describes Network metric attributes" + attributes: - id: state type: allow_custom_values: false @@ -422,7 +433,7 @@ groups: from [`GetIfEntry2`](https://docs.microsoft.com/windows/win32/api/netioapi/nf-netioapi-getifentry2) attributes: - ref: system.device - - ref: system.network.direction + - ref: network.io.direction - id: metric.system.network.packets type: metric @@ -432,7 +443,7 @@ groups: unit: "{packet}" attributes: - ref: system.device - - ref: system.network.direction + - ref: network.io.direction - id: metric.system.network.errors type: metric @@ -448,7 +459,7 @@ groups: from [`GetIfEntry2`](https://docs.microsoft.com/windows/win32/api/netioapi/nf-netioapi-getifentry2). attributes: - ref: system.device - - ref: system.network.direction + - ref: network.io.direction - id: metric.system.network.io type: metric @@ -458,7 +469,7 @@ groups: unit: "By" attributes: - ref: system.device - - ref: system.network.direction + - ref: network.io.direction - id: metric.system.network.connections type: metric From b2068e905216998069042ca109ffb62d018cf10a Mon Sep 17 00:00:00 2001 From: braydonk Date: Thu, 16 Nov 2023 14:56:46 +0000 Subject: [PATCH 02/15] make table-generation --- docs/system/system-metrics.md | 40 +++++++++++++++++------------------ 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/docs/system/system-metrics.md b/docs/system/system-metrics.md index d5848d424d..3248c7ea55 100644 --- a/docs/system/system-metrics.md +++ b/docs/system/system-metrics.md @@ -359,10 +359,10 @@ This metric is [recommended][MetricRecommended]. | Attribute | Type | Description | Examples | Requirement Level | |---|---|---|---|---| +| `disk.io.direction` | string | The disk IO operation direction | `read` | Recommended | | `system.device` | string | The device identifier | `(identifier)` | Recommended | -| `system.disk.direction` | string | The disk operation direction | `read` | Recommended | -`system.disk.direction` MUST be one of the following: +`disk.io.direction` MUST be one of the following: | Value | Description | |---|---| @@ -383,10 +383,10 @@ This metric is [recommended][MetricRecommended]. | Attribute | Type | Description | Examples | Requirement Level | |---|---|---|---|---| +| `disk.io.direction` | string | The disk IO operation direction | `read` | Recommended | | `system.device` | string | The device identifier | `(identifier)` | Recommended | -| `system.disk.direction` | string | The disk operation direction | `read` | Recommended | -`system.disk.direction` MUST be one of the following: +`disk.io.direction` MUST be one of the following: | Value | Description | |---|---| @@ -435,10 +435,10 @@ This metric is [recommended][MetricRecommended]. | Attribute | Type | Description | Examples | Requirement Level | |---|---|---|---|---| +| `disk.io.direction` | string | The disk IO operation direction | `read` | Recommended | | `system.device` | string | The device identifier | `(identifier)` | Recommended | -| `system.disk.direction` | string | The disk operation direction | `read` | Recommended | -`system.disk.direction` MUST be one of the following: +`disk.io.direction` MUST be one of the following: | Value | Description | |---|---| @@ -459,10 +459,10 @@ This metric is [recommended][MetricRecommended]. | Attribute | Type | Description | Examples | Requirement Level | |---|---|---|---|---| +| `disk.io.direction` | string | The disk IO operation direction | `read` | Recommended | | `system.device` | string | The device identifier | `(identifier)` | Recommended | -| `system.disk.direction` | string | The disk operation direction | `read` | Recommended | -`system.disk.direction` MUST be one of the following: +`disk.io.direction` MUST be one of the following: | Value | Description | |---|---| @@ -575,14 +575,14 @@ This metric is [recommended][MetricRecommended]. | Attribute | Type | Description | Examples | Requirement Level | |---|---|---|---|---| +| `network.io.direction` | string | The network IO operation direction | `send` | Recommended | | `system.device` | string | The device identifier | `(identifier)` | Recommended | -| `system.network.direction` | string | | `transmit` | Recommended | -`system.network.direction` MUST be one of the following: +`network.io.direction` MUST be one of the following: | Value | Description | |---|---| -| `transmit` | transmit | +| `send` | send | | `receive` | receive | @@ -599,14 +599,14 @@ This metric is [recommended][MetricRecommended]. | Attribute | Type | Description | Examples | Requirement Level | |---|---|---|---|---| +| `network.io.direction` | string | The network IO operation direction | `send` | Recommended | | `system.device` | string | The device identifier | `(identifier)` | Recommended | -| `system.network.direction` | string | | `transmit` | Recommended | -`system.network.direction` MUST be one of the following: +`network.io.direction` MUST be one of the following: | Value | Description | |---|---| -| `transmit` | transmit | +| `send` | send | | `receive` | receive | @@ -629,14 +629,14 @@ This metric is [recommended][MetricRecommended]. | Attribute | Type | Description | Examples | Requirement Level | |---|---|---|---|---| +| `network.io.direction` | string | The network IO operation direction | `send` | Recommended | | `system.device` | string | The device identifier | `(identifier)` | Recommended | -| `system.network.direction` | string | | `transmit` | Recommended | -`system.network.direction` MUST be one of the following: +`network.io.direction` MUST be one of the following: | Value | Description | |---|---| -| `transmit` | transmit | +| `send` | send | | `receive` | receive | @@ -653,14 +653,14 @@ This metric is [recommended][MetricRecommended]. | Attribute | Type | Description | Examples | Requirement Level | |---|---|---|---|---| +| `network.io.direction` | string | The network IO operation direction | `send` | Recommended | | `system.device` | string | The device identifier | `(identifier)` | Recommended | -| `system.network.direction` | string | | `transmit` | Recommended | -`system.network.direction` MUST be one of the following: +`network.io.direction` MUST be one of the following: | Value | Description | |---|---| -| `transmit` | transmit | +| `send` | send | | `receive` | receive | From 1bb5ef9647464e959d85e40d56f324d36d704a9d Mon Sep 17 00:00:00 2001 From: Braydon Kains Date: Sat, 18 Nov 2023 16:38:31 -0500 Subject: [PATCH 03/15] move io direction attributes to global registry --- model/metrics/system-metrics.yaml | 35 ------------------------------- model/registry/disk.yaml | 17 +++++++++++++++ model/registry/network.yaml | 10 +++++++++ 3 files changed, 27 insertions(+), 35 deletions(-) create mode 100644 model/registry/disk.yaml diff --git a/model/metrics/system-metrics.yaml b/model/metrics/system-metrics.yaml index 44118d45c7..0359a3f341 100644 --- a/model/metrics/system-metrics.yaml +++ b/model/metrics/system-metrics.yaml @@ -213,24 +213,6 @@ groups: - ref: system.paging.direction # system.disk.* metrics and attribute group - - # General disk attributes - - id: attributes.disk - prefix: disk - type: attribute_group - brief: "Describes attributes used in disk-related metrics" - attributes: - - id: io.direction - type: - allow_custom_values: false - members: - - id: read - value: 'read' - - id: write - value: 'write' - brief: "The disk IO operation direction" - examples: ["read"] - - id: metric.system.disk.io type: metric metric_name: system.disk.io @@ -365,23 +347,6 @@ groups: # system.network.* metrics and attribute group - # General network attributes - - id: attributes.network - prefix: network - type: attribute_group - brief: "Describes attributes used in network-related metrics" - attributes: - - id: io.direction - type: - allow_custom_values: false - members: - - id: send - value: 'send' - - id: receive - value: 'receive' - brief: "The network IO operation direction" - examples: ["send"] - # System-specific network attributes - id: attributes.system.network prefix: system.network diff --git a/model/registry/disk.yaml b/model/registry/disk.yaml new file mode 100644 index 0000000000..2e3d387472 --- /dev/null +++ b/model/registry/disk.yaml @@ -0,0 +1,17 @@ +groups: + - id: registry.disk + prefix: disk + type: attribute_group + brief: > + These attributes may be used for any disk related operation. + attributes: + - id: io.direction + type: + allow_custom_values: false + members: + - id: read + value: 'read' + - id: write + value: 'write' + brief: "The disk IO operation direction" + examples: ["read"] diff --git a/model/registry/network.yaml b/model/registry/network.yaml index 27b072a08c..d50ed982ec 100644 --- a/model/registry/network.yaml +++ b/model/registry/network.yaml @@ -182,3 +182,13 @@ groups: brief: '[OSI network layer](https://osi-model.com/network-layer/) or non-OSI equivalent.' note: The value SHOULD be normalized to lowercase. examples: ['ipv4', 'ipv6'] + - id: io.direction + type: + allow_custom_values: false + members: + - id: transmit + value: 'transmit' + - id: receive + value: 'receive' + brief: "The network IO operation direction" + examples: ["transmit"] From 315ec6fdaeb2e5a7f4a70cf799411918b0d142c6 Mon Sep 17 00:00:00 2001 From: braydonk Date: Sat, 18 Nov 2023 21:41:01 +0000 Subject: [PATCH 04/15] table generation for global registry attributes --- docs/attributes-registry/network.md | 8 ++++++++ docs/system/system-metrics.md | 16 ++++++++-------- model/metrics/system-metrics.yaml | 4 ++-- 3 files changed, 18 insertions(+), 10 deletions(-) diff --git a/docs/attributes-registry/network.md b/docs/attributes-registry/network.md index 77f00acedd..aab10b446c 100644 --- a/docs/attributes-registry/network.md +++ b/docs/attributes-registry/network.md @@ -16,6 +16,7 @@ These attributes may be used for any network related operation. | `network.carrier.name` | string | The name of the mobile carrier. | `sprint` | | `network.connection.subtype` | string | This describes more details regarding the connection.type. It may be the type of cell technology connection, but it could be used for describing details about a wifi connection. | `LTE` | | `network.connection.type` | string | The internet connection type. | `wifi` | +| `network.io.direction` | string | The network IO operation direction | `transmit` | | `network.local.address` | string | ![Stable](https://img.shields.io/badge/-stable-lightgreen)
Local address of the network connection - IP address or Unix domain socket name. | `10.1.2.80`; `/tmp/my.sock` | | `network.local.port` | int | ![Stable](https://img.shields.io/badge/-stable-lightgreen)
Local port number of the network connection. | `65123` | | `network.peer.address` | string | ![Stable](https://img.shields.io/badge/-stable-lightgreen)
Peer address of the network connection - IP address or Unix domain socket name. | `10.1.2.80`; `/tmp/my.sock` | @@ -73,6 +74,13 @@ different processes could be listening on TCP port 12345 and UDP port 12345. | `unavailable` | unavailable | | `unknown` | unknown | +`network.io.direction` MUST be one of the following: + +| Value | Description | +|---|---| +| `transmit` | transmit | +| `receive` | receive | + `network.transport` has the following list of well-known values. If one of them applies, then the respective value MUST be used, otherwise a custom value MAY be used. | Value | Description | diff --git a/docs/system/system-metrics.md b/docs/system/system-metrics.md index 3248c7ea55..6fe10bb081 100644 --- a/docs/system/system-metrics.md +++ b/docs/system/system-metrics.md @@ -575,14 +575,14 @@ This metric is [recommended][MetricRecommended]. | Attribute | Type | Description | Examples | Requirement Level | |---|---|---|---|---| -| `network.io.direction` | string | The network IO operation direction | `send` | Recommended | +| [`network.io.direction`](../attributes-registry/network.md) | string | The network IO operation direction | `transmit` | Recommended | | `system.device` | string | The device identifier | `(identifier)` | Recommended | `network.io.direction` MUST be one of the following: | Value | Description | |---|---| -| `send` | send | +| `transmit` | transmit | | `receive` | receive | @@ -599,14 +599,14 @@ This metric is [recommended][MetricRecommended]. | Attribute | Type | Description | Examples | Requirement Level | |---|---|---|---|---| -| `network.io.direction` | string | The network IO operation direction | `send` | Recommended | +| [`network.io.direction`](../attributes-registry/network.md) | string | The network IO operation direction | `transmit` | Recommended | | `system.device` | string | The device identifier | `(identifier)` | Recommended | `network.io.direction` MUST be one of the following: | Value | Description | |---|---| -| `send` | send | +| `transmit` | transmit | | `receive` | receive | @@ -629,14 +629,14 @@ This metric is [recommended][MetricRecommended]. | Attribute | Type | Description | Examples | Requirement Level | |---|---|---|---|---| -| `network.io.direction` | string | The network IO operation direction | `send` | Recommended | +| [`network.io.direction`](../attributes-registry/network.md) | string | The network IO operation direction | `transmit` | Recommended | | `system.device` | string | The device identifier | `(identifier)` | Recommended | `network.io.direction` MUST be one of the following: | Value | Description | |---|---| -| `send` | send | +| `transmit` | transmit | | `receive` | receive | @@ -653,14 +653,14 @@ This metric is [recommended][MetricRecommended]. | Attribute | Type | Description | Examples | Requirement Level | |---|---|---|---|---| -| `network.io.direction` | string | The network IO operation direction | `send` | Recommended | +| [`network.io.direction`](../attributes-registry/network.md) | string | The network IO operation direction | `transmit` | Recommended | | `system.device` | string | The device identifier | `(identifier)` | Recommended | `network.io.direction` MUST be one of the following: | Value | Description | |---|---| -| `send` | send | +| `transmit` | transmit | | `receive` | receive | diff --git a/model/metrics/system-metrics.yaml b/model/metrics/system-metrics.yaml index 0359a3f341..d411115ea8 100644 --- a/model/metrics/system-metrics.yaml +++ b/model/metrics/system-metrics.yaml @@ -345,8 +345,8 @@ groups: - ref: system.filesystem.mode - ref: system.filesystem.mountpoint - # system.network.* metrics and attribute group - + # system.network.* metrics and attribute group + # System-specific network attributes - id: attributes.system.network prefix: system.network From 061809686de7719bf0f9b220897993b074f200bd Mon Sep 17 00:00:00 2001 From: Alexander Wert Date: Wed, 22 Nov 2023 07:45:47 +0100 Subject: [PATCH 05/15] Update model/registry/network.yaml --- model/registry/network.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/model/registry/network.yaml b/model/registry/network.yaml index d50ed982ec..7715506bcc 100644 --- a/model/registry/network.yaml +++ b/model/registry/network.yaml @@ -190,5 +190,5 @@ groups: value: 'transmit' - id: receive value: 'receive' - brief: "The network IO operation direction" + brief: "The network IO operation direction." examples: ["transmit"] From 89c55520bf6530669d46e35ca490edde3b1e9ec6 Mon Sep 17 00:00:00 2001 From: Alexander Wert Date: Wed, 22 Nov 2023 07:45:54 +0100 Subject: [PATCH 06/15] Update model/registry/disk.yaml --- model/registry/disk.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/model/registry/disk.yaml b/model/registry/disk.yaml index 2e3d387472..90d6fb27d2 100644 --- a/model/registry/disk.yaml +++ b/model/registry/disk.yaml @@ -13,5 +13,5 @@ groups: value: 'read' - id: write value: 'write' - brief: "The disk IO operation direction" + brief: "The disk IO operation direction." examples: ["read"] From b170d7e3eaa08cc6619435f5ebc407b43be890d0 Mon Sep 17 00:00:00 2001 From: Alexander Wert Date: Wed, 22 Nov 2023 11:17:24 +0100 Subject: [PATCH 07/15] Update docs/attributes-registry/network.md --- docs/attributes-registry/network.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/attributes-registry/network.md b/docs/attributes-registry/network.md index aab10b446c..a6c5907728 100644 --- a/docs/attributes-registry/network.md +++ b/docs/attributes-registry/network.md @@ -16,7 +16,7 @@ These attributes may be used for any network related operation. | `network.carrier.name` | string | The name of the mobile carrier. | `sprint` | | `network.connection.subtype` | string | This describes more details regarding the connection.type. It may be the type of cell technology connection, but it could be used for describing details about a wifi connection. | `LTE` | | `network.connection.type` | string | The internet connection type. | `wifi` | -| `network.io.direction` | string | The network IO operation direction | `transmit` | +| `network.io.direction` | string | The network IO operation direction. | `transmit` | | `network.local.address` | string | ![Stable](https://img.shields.io/badge/-stable-lightgreen)
Local address of the network connection - IP address or Unix domain socket name. | `10.1.2.80`; `/tmp/my.sock` | | `network.local.port` | int | ![Stable](https://img.shields.io/badge/-stable-lightgreen)
Local port number of the network connection. | `65123` | | `network.peer.address` | string | ![Stable](https://img.shields.io/badge/-stable-lightgreen)
Peer address of the network connection - IP address or Unix domain socket name. | `10.1.2.80`; `/tmp/my.sock` | From f0f9f2b46d4d62c12782904a9569b6d87a1224d6 Mon Sep 17 00:00:00 2001 From: Alexander Wert Date: Wed, 22 Nov 2023 11:17:31 +0100 Subject: [PATCH 08/15] Update docs/system/system-metrics.md --- docs/system/system-metrics.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/system/system-metrics.md b/docs/system/system-metrics.md index 6fe10bb081..657caf243a 100644 --- a/docs/system/system-metrics.md +++ b/docs/system/system-metrics.md @@ -383,7 +383,7 @@ This metric is [recommended][MetricRecommended]. | Attribute | Type | Description | Examples | Requirement Level | |---|---|---|---|---| -| `disk.io.direction` | string | The disk IO operation direction | `read` | Recommended | +| `disk.io.direction` | string | The disk IO operation direction. | `read` | Recommended | | `system.device` | string | The device identifier | `(identifier)` | Recommended | `disk.io.direction` MUST be one of the following: From ad18ddff67f8081b455c174065ce10119e96b596 Mon Sep 17 00:00:00 2001 From: Alexander Wert Date: Wed, 22 Nov 2023 11:17:37 +0100 Subject: [PATCH 09/15] Update docs/system/system-metrics.md --- docs/system/system-metrics.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/system/system-metrics.md b/docs/system/system-metrics.md index 657caf243a..b5a9f8dfdf 100644 --- a/docs/system/system-metrics.md +++ b/docs/system/system-metrics.md @@ -435,7 +435,7 @@ This metric is [recommended][MetricRecommended]. | Attribute | Type | Description | Examples | Requirement Level | |---|---|---|---|---| -| `disk.io.direction` | string | The disk IO operation direction | `read` | Recommended | +| `disk.io.direction` | string | The disk IO operation direction. | `read` | Recommended | | `system.device` | string | The device identifier | `(identifier)` | Recommended | `disk.io.direction` MUST be one of the following: From f8a33ca6277379582c8066401ea6c4c51319a20b Mon Sep 17 00:00:00 2001 From: Alexander Wert Date: Wed, 22 Nov 2023 11:17:43 +0100 Subject: [PATCH 10/15] Update docs/system/system-metrics.md --- docs/system/system-metrics.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/system/system-metrics.md b/docs/system/system-metrics.md index b5a9f8dfdf..0f28172c4e 100644 --- a/docs/system/system-metrics.md +++ b/docs/system/system-metrics.md @@ -459,7 +459,7 @@ This metric is [recommended][MetricRecommended]. | Attribute | Type | Description | Examples | Requirement Level | |---|---|---|---|---| -| `disk.io.direction` | string | The disk IO operation direction | `read` | Recommended | +| `disk.io.direction` | string | The disk IO operation direction. | `read` | Recommended | | `system.device` | string | The device identifier | `(identifier)` | Recommended | `disk.io.direction` MUST be one of the following: From 8bfae173fee94cb8423bbd29a835a67592cf6b33 Mon Sep 17 00:00:00 2001 From: Alexander Wert Date: Wed, 22 Nov 2023 11:17:51 +0100 Subject: [PATCH 11/15] Update docs/system/system-metrics.md --- docs/system/system-metrics.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/system/system-metrics.md b/docs/system/system-metrics.md index 0f28172c4e..b4739ad206 100644 --- a/docs/system/system-metrics.md +++ b/docs/system/system-metrics.md @@ -629,7 +629,7 @@ This metric is [recommended][MetricRecommended]. | Attribute | Type | Description | Examples | Requirement Level | |---|---|---|---|---| -| [`network.io.direction`](../attributes-registry/network.md) | string | The network IO operation direction | `transmit` | Recommended | +| [`network.io.direction`](../attributes-registry/network.md) | string | The network IO operation direction. | `transmit` | Recommended | | `system.device` | string | The device identifier | `(identifier)` | Recommended | `network.io.direction` MUST be one of the following: From 6c9d5fccd6b1e864eb2662672f65433ecf9caaf7 Mon Sep 17 00:00:00 2001 From: Alexander Wert Date: Wed, 22 Nov 2023 11:17:58 +0100 Subject: [PATCH 12/15] Update docs/system/system-metrics.md --- docs/system/system-metrics.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/system/system-metrics.md b/docs/system/system-metrics.md index b4739ad206..59b3862429 100644 --- a/docs/system/system-metrics.md +++ b/docs/system/system-metrics.md @@ -653,7 +653,7 @@ This metric is [recommended][MetricRecommended]. | Attribute | Type | Description | Examples | Requirement Level | |---|---|---|---|---| -| [`network.io.direction`](../attributes-registry/network.md) | string | The network IO operation direction | `transmit` | Recommended | +| [`network.io.direction`](../attributes-registry/network.md) | string | The network IO operation direction. | `transmit` | Recommended | | `system.device` | string | The device identifier | `(identifier)` | Recommended | `network.io.direction` MUST be one of the following: From bdeaca258e031c076f326f68f1017006e53c392c Mon Sep 17 00:00:00 2001 From: Alexander Wert Date: Wed, 22 Nov 2023 11:18:04 +0100 Subject: [PATCH 13/15] Update docs/system/system-metrics.md --- docs/system/system-metrics.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/system/system-metrics.md b/docs/system/system-metrics.md index 59b3862429..647e26030b 100644 --- a/docs/system/system-metrics.md +++ b/docs/system/system-metrics.md @@ -575,7 +575,7 @@ This metric is [recommended][MetricRecommended]. | Attribute | Type | Description | Examples | Requirement Level | |---|---|---|---|---| -| [`network.io.direction`](../attributes-registry/network.md) | string | The network IO operation direction | `transmit` | Recommended | +| [`network.io.direction`](../attributes-registry/network.md) | string | The network IO operation direction. | `transmit` | Recommended | | `system.device` | string | The device identifier | `(identifier)` | Recommended | `network.io.direction` MUST be one of the following: From 91436d6eaab0e52ffa84a990eadf8336cd450c18 Mon Sep 17 00:00:00 2001 From: Alexander Wert Date: Wed, 22 Nov 2023 11:18:11 +0100 Subject: [PATCH 14/15] Update docs/system/system-metrics.md --- docs/system/system-metrics.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/system/system-metrics.md b/docs/system/system-metrics.md index 647e26030b..a87382821b 100644 --- a/docs/system/system-metrics.md +++ b/docs/system/system-metrics.md @@ -359,7 +359,7 @@ This metric is [recommended][MetricRecommended]. | Attribute | Type | Description | Examples | Requirement Level | |---|---|---|---|---| -| `disk.io.direction` | string | The disk IO operation direction | `read` | Recommended | +| `disk.io.direction` | string | The disk IO operation direction. | `read` | Recommended | | `system.device` | string | The device identifier | `(identifier)` | Recommended | `disk.io.direction` MUST be one of the following: From 638b97eba4fb708f36ed3688aac2487590c7d2f7 Mon Sep 17 00:00:00 2001 From: Alexander Wert Date: Wed, 22 Nov 2023 11:19:55 +0100 Subject: [PATCH 15/15] Update docs/system/system-metrics.md --- docs/system/system-metrics.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/system/system-metrics.md b/docs/system/system-metrics.md index a87382821b..f33a871e4a 100644 --- a/docs/system/system-metrics.md +++ b/docs/system/system-metrics.md @@ -599,7 +599,7 @@ This metric is [recommended][MetricRecommended]. | Attribute | Type | Description | Examples | Requirement Level | |---|---|---|---|---| -| [`network.io.direction`](../attributes-registry/network.md) | string | The network IO operation direction | `transmit` | Recommended | +| [`network.io.direction`](../attributes-registry/network.md) | string | The network IO operation direction. | `transmit` | Recommended | | `system.device` | string | The device identifier | `(identifier)` | Recommended | `network.io.direction` MUST be one of the following: