Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

analyzer: Plugins are objects, not functions #62

Open
jsantell opened this issue May 20, 2021 · 0 comments
Open

analyzer: Plugins are objects, not functions #62

jsantell opened this issue May 20, 2021 · 0 comments

Comments

@jsantell
Copy link

via the README, Plugins are defined as functions, including the example:

A plugin is a function that returns an object. There are several hooks you can opt in to:

However, the current implementation defines a Plugin as an object with analyzePhase, and other callbacks. While plugins in npm (and the built in lit and stencil plugins) may expose functions, the plugins array must ultimately be an object.

Happy to send PR with doc changes, but want to confirm the intentions here first.

@jsantell jsantell changed the title Plugins are objects, not functions analyzer: Plugins are objects, not functions May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant