Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename user to contributor in all relevant places #1804

Open
4 of 5 tasks
kiragrammel opened this issue Jul 27, 2023 · 0 comments
Open
4 of 5 tasks

Rename user to contributor in all relevant places #1804

kiragrammel opened this issue Jul 27, 2023 · 0 comments
Labels
enhancement ruby Pull requests that update Ruby code

Comments

@kiragrammel
Copy link
Contributor

kiragrammel commented Jul 27, 2023

In the prototype-pair-programming branch in the table submissions the column user_id and user_type were changed to contributor_id and contributor_type because a exercise can now also be submitted as a group.
The alias method alias_method :user, :contributor was added for this purpose in the ContributorCreation. It is cleaner if this is not needed and all places use the contributor instead.

Also, it probably makes sense to talk about contributor instead of user in the following other tables as well, allowing groups to be contributors as well:

  • ❌ request_for_comments -> An individual user is requesting the RfC and others might have access through the group
  • ✅ runner
  • user_exercise_interventions
  • ❌ user_proxy_exercise_exercises (relevant e.g. for Java courses) -> This assignment to a proxy exercise is performed before forming a group. Therefore, it is always an individual.
  • ❌ user_exercise_feedbacks -> Individuals provide feedback; this could be different for all members of the group. Since we have the link to the submission, we can always reconstruct who was a member of the group (if any).
@kiragrammel kiragrammel added enhancement ruby Pull requests that update Ruby code labels Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ruby Pull requests that update Ruby code
Projects
None yet
Development

No branches or pull requests

1 participant