Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change mastodon icon to font awesome #1932

Open
1 of 3 tasks
Janfred opened this issue Jan 5, 2018 · 2 comments
Open
1 of 3 tasks

Change mastodon icon to font awesome #1932

Janfred opened this issue Jan 5, 2018 · 2 comments
Assignees

Comments

@Janfred
Copy link
Contributor

Janfred commented Jan 5, 2018

I'm submitting a ..

  • Bug Report
  • Feature Request
  • Code smell issue

Current behavior:
With #1839 osem has the possibility to link to mastodon. Currently the icon is not in font awesome, so a special font is embedded.

Expected correct behavior:
Once a mastodon icon is included in font awesome the code should be reworked to use the font awesome icon instead of the custom font.

Other information:
Font Awesome Issue: FortAwesome/Font-Awesome#10897
I'll submit a pull request once the icon is included in FontAwesome

@xuv
Copy link

xuv commented Apr 27, 2018

If you wish, you can take a look at Fork Awesome, a fork of Font Awesome 4.7, that includes a lot of open source logos, and Mastodon in different flavors:

@Janfred
Copy link
Contributor Author

Janfred commented Apr 22, 2019

The icon is available in FontAwesome 5.0.11 (See linked FontAwesome Issue in the initial post)

Anyway, the font-awesome-rails gem does not yet support the font-awesome 5.x versions, and maybe never will, since it requires a complete rewrite of the gem according to bokmann/font-awesome-rails#194

It might be a good idea to switch to direct font awesome, as suggested in bokmann/font-awesome-rails#194 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants