Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"2nd Thursday of the month" is unrepresentable #268

Open
lukehesluke opened this issue Mar 29, 2021 · 0 comments
Open

"2nd Thursday of the month" is unrepresentable #268

lukehesluke opened this issue Mar 29, 2021 · 0 comments

Comments

@lukehesluke
Copy link

In this issue, it was indicated that we would want to support "2nd Thursday of the month"-type schedules: #2 (comment).

This is what would be represented by byDay: '2TH'.

However, other rules of the modelling spec make this unrepresentable:

  1. byDay is only supported for sessions with weekly occurrence (as is being implemented in this PR. Specifically, in this bit of code)

    byMonthDay is supported for sessions with monthly occurrence. But it is not possible to specify "2nd Thursday of the month" with this

  2. byDay must be an array. This is very minor - byDay: ['2TH'] could in theory be representable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant