Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly-incorrect sensitivity used in forecasts #1445

Open
dburren opened this issue Dec 29, 2022 · 1 comment
Open

Possibly-incorrect sensitivity used in forecasts #1445

dburren opened this issue Dec 29, 2022 · 1 comment

Comments

@dburren
Copy link

dburren commented Dec 29, 2022

The code (as at 0.7.1) takes the profile sensitivity (for now) and scales that by sensitivityRatio.
It then uses that in making forecasts over the coming hours.

However the profile's declared sensitivity can change over time.

If the sensitivity does actually change over time, should we not be using the declared sensitivity for each time block (again scaled by sensitivityRatio)?

A follow-on issue may be that the declared CSF (ratio of ISF:ICR) can change, which affects remainingCarbs and remainingCIpeak.

@scottleibrand
Copy link
Contributor

OpenAPS mostly assumes that ISF doesn't change (much) over the course of the day, and models diurnal patterns onto basals. Lots of people asserted based on anecdata that their ISF or (usually) CR changes over the day, and we came up with a design for autotuning CR, but no one ever got interested enough to actually implement/test that. Then AndroidAPS implemented fully tunable profiles, and lots of people went off and implemented whatever they thought was correct for them, and everyone lost interest in coming up with a more general solution.

In short, we don't have any data to indicate whether the behavior you describe would work better than the current behavior, and testing it would be quite difficult given how variable the source of the original profile sensitivity schedule is.

But if you'd like to, we could probably figure out how to implement a change and test it in the oref0-backtest simulator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants