Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide created but unused slots in Kexec-Multiboot #3380

Open
pololoko111 opened this issue Jul 11, 2024 · 7 comments
Open

Hide created but unused slots in Kexec-Multiboot #3380

pololoko111 opened this issue Jul 11, 2024 · 7 comments

Comments

@pololoko111
Copy link
Contributor

Request to hide created but unused slots in Kexec-Multiboot.
In OpenATV, the created slots appear empty.

empty

I will ask you to hide empty slots like they did in OpenBH.
OpenBH unused slots are hidden.
Thanks in advance.

hiden

@IanSav
Copy link
Contributor

IanSav commented Jul 13, 2024

Why do you want to hide resources that may be helpful to users? If there are slots free that can be used then I think it appropriate that users be shown that the resources are there and available for use. If they are hidden then their availability might be forgotten.

@pololoko111
Copy link
Contributor Author

I think it looks better visually when you can't see the empty slots.
You also don't have to go through empty slots if you want to go (in my case) from slot 1 to slot 4.
I don't know if kexec multiboot users have short memory 😄 to forget that you have empty slots. 😃
If it stays as it is now, it won't be the end of the world.
Thank you. Regards.

@pololoko111
Copy link
Contributor Author

Also if the image is installed on the sdcard it shows as usb.
sdusb

As in the photo below.
sccorrect

@wedebe
Copy link
Contributor

wedebe commented Jul 30, 2024

I like this idea. It would be nice to have it as a user-configurable option Hide unused multi-boot slots

@jbleyel
Copy link
Contributor

jbleyel commented Jul 30, 2024

I like this idea. It would be nice to have it as a user-configurable option Hide unused multi-boot slots

This makes no sense if you ask me.
What if you wanna select an empty slot to flash an image on this slot!

@wedebe
Copy link
Contributor

wedebe commented Jul 30, 2024

HWhat if you wanna select an empty slot to flash an image on this slot!

By default, all slots would be visible. If the user had set their preference to hide unused, they would show them again by changing the Hide unused multi-boot slotssetting to Yes.

@pololoko111
Copy link
Contributor Author

pololoko111 commented Jul 31, 2024

Hide unused multi-boot slots

This option is not needed, just modify the code.
Image selector - slots are hidden
SHI

Flash image - slots still available.
SA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants