Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control: Documentaion #16

Open
msbarth opened this issue Feb 13, 2019 · 5 comments
Open

Control: Documentaion #16

msbarth opened this issue Feb 13, 2019 · 5 comments

Comments

@msbarth
Copy link
Contributor

msbarth commented Feb 13, 2019

Create basic documentation for how phosphor-fan-presence fan control is configured and works based on configured events.

@nguyenchanh2201
Copy link

Great! Current, I'm hard to understand the configuration in YAML event file.

Hi @msbarth, Do you have any document to describe clearly fan control is configured and works?

@msbarth
Copy link
Contributor Author

msbarth commented Aug 27, 2020

At this time, I do not. There's a strategic direction change to move to JSON configuration files in place of YAML which is what I'm working on currently. The best option to understand the configuration in the events.yaml file would be to look at the example yaml file (https://github.com/openbmc/phosphor-fan-presence/blob/master/control/example/events.yaml) and the witherspoon machine configuration that's using fan control (https://github.com/openbmc/openbmc/blob/master/meta-ibm/recipes-phosphor/fans/phosphor-fan-control-events-config/witherspoon/events.yaml)

You can also see the other fan application configurations for the witherspoon machine under (https://github.com/openbmc/openbmc/blob/master/meta-ibm/recipes-phosphor/fans/).

@msbarth
Copy link
Contributor Author

msbarth commented Aug 27, 2020

My plan is to get some documentation out after the conversion to using JSON configuration files is complete. The documentation will only reflect on the use of JSON configuration files which are planned to replace the use of YAML files.

@msbarth
Copy link
Contributor Author

msbarth commented Apr 27, 2021

Current state of documentation for each fan application -> https://github.com/openbmc/phosphor-fan-presence/blob/master/README.md

The fan control application is still undergoing its support of using JSON configuration files and the documentation will be updated to reflect that once complete. The other fan apps have been converted and the use of JSON configuration files has been documented in the readme.

@williamspatrick
Copy link
Member

I was looking at docs/control/README.md (after being pointed there by the root README.md) and it is a whole bunch of TBD. It looks like the only examples are over in openbmc/openbmc?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants