Skip to content

Commit

Permalink
Merge pull request #5 from martasoricetti/main
Browse files Browse the repository at this point in the history
fix jalc_process.py('citation_list' error key) + crossref test + jalc_languages_metadata_count
  • Loading branch information
ariannamorettj committed Oct 27, 2023
2 parents a5316f0 + dda1d38 commit 9d6960b
Show file tree
Hide file tree
Showing 18 changed files with 1,885 additions and 495 deletions.
6 changes: 3 additions & 3 deletions oc_ds_converter/crossref/crossref_processing.py
Original file line number Diff line number Diff line change
Expand Up @@ -129,9 +129,9 @@ def to_validated_id_list(self, norm_id_dict):

def memory_to_storage(self):
kv_in_memory = self.temporary_manager.get_validity_list_of_tuples()
#if kv_in_memory:
self.storage_manager.set_multi_value(kv_in_memory)
self.temporary_manager.delete_storage()
if kv_in_memory:
self.storage_manager.set_multi_value(kv_in_memory)
self.temporary_manager.delete_storage()


def validated_as(self, id_dict):
Expand Down
5 changes: 2 additions & 3 deletions oc_ds_converter/datacite/datacite_processing.py
Original file line number Diff line number Diff line change
Expand Up @@ -303,8 +303,7 @@ def get_datacite_pages(self, item: dict) -> str:
related_pages_list = list()
container = item.get("container")
if container:
if container.get("identifierType") == "ISSN" or container.get(
"identifierType") == "ISBN":
if container.get("identifierType") == "ISSN" or container.get("identifierType") == "ISBN":
if container.get("firstPage"):
container_pages_list.append(container.get("firstPage"))
if container.get("lastPage"):
Expand Down Expand Up @@ -477,7 +476,7 @@ def add_editors_to_agent_list(self, item: dict, ag_list: list) -> list:

def add_authors_to_agent_list(self, item: dict, ag_list: list) -> list:
'''
This function returns the the agents list updated with the authors dictionaries, in the correct format.
This function returns the agents list updated with the authors dictionaries, in the correct format.
:params item: the item's dictionary (attributes), ag_list: the
:type item: dict, ag_list: list
Expand Down
Loading

0 comments on commit 9d6960b

Please sign in to comment.