Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UseCaseTitle typo, chassistype enumeration values to add #69

Open
plmanik opened this issue Mar 18, 2024 · 3 comments · May be fixed by #70
Open

UseCaseTitle typo, chassistype enumeration values to add #69

plmanik opened this issue Mar 18, 2024 · 3 comments · May be fixed by #70

Comments

@plmanik
Copy link

plmanik commented Mar 18, 2024

Hi,
We are seeing three issues based on https://github.com/opencomputeproject/HWMgmt-OCP-Profiles/blob/master/HWMgmt/OCPBaselineHardwareManagement.v1_1_0.json

Issue 1
UseCase.The_primary_Chassis_requirements..ReadRequirement | Mandatory | Must Exist | DNE | FAIL |

Able to see .. before ReadRequirement and it's coming due to "UseCaseTitle": "The primary Chassis requirements**.**", definition in profile.
Is this going to fix in profile or in Redfish-Interop-Validator?
If we remove . from "UseCaseTitle": "The primary Chassis requirements" failure is not coming

Issue 2
UseCase.The_Manager_providing_Redfish_service..ReadRequirement | Mandatory | Must Exist | DNE | FAIL
Able to see .. before ReadRequirement and it's coming due to "UseCaseTitle": "The Manager providing Redfish service**.**", definition in profile.
Is this going to fix in profile or in Redfish-Interop-Validator? If we remove . from "UseCaseTitle": "The Manager providing Redfish service" failure is not coming

Issue 3
"UseCaseKeyProperty": "ChassisType",
"UseCaseComparison": "Equal",
"UseCaseKeyValues": ["Drawer", "RackMount", "Sled"],
As per schema we have other values also applicable like below, can we add above all values in UseCaseKeyValues
"ChassisType": {
"enum": [
"Rack",
"Blade",
"Enclosure",
"StandAlone",
"RackMount",
"Card",
"Cartridge",
"Row",
"Pod",
"Expansion",
"Sidecar",
"Zone",
"Sled",
"Shelf",
"Drawer",
"Module",
"Component",
"IPBasedDrive",
"RackGroup",
"StorageEnclosure",
"ImmersionTank",
"HeatExchanger",
"PowerStrip",
"Other"
],

Thanks,
Mani

@jcleung5549
Copy link
Contributor

The issues 1 and 2 should be fixed in PR #70.

@jcleung5549
Copy link
Contributor

Regarding issue 3, the enumeration is to align with the ChassisType's specified in the Server profile. Adding the entire enumeration who obviate the need to have the UseCase semantic. Is there a specific ChassisType value you are having problems testing?

@plmanik
Copy link
Author

plmanik commented Apr 23, 2024

@jcleung5549 We are using StandAlone, Other enum values

@lindappwu lindappwu linked a pull request Oct 7, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants