-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oom_get_keyvalue_cached should be eliminated #6
Comments
oom_get_keyvalue_cached() is almost identical to oom_get_keyvalue(). Pass in an optional flag to force use of cached data, use the flag as: |
Yes. You are right. |
The purpose of cached reads is to allow multiple dynamic keys to be read in a single access. The obvious case is reading DOM data. This requires a read of temp, voltage, Tx/Rx power and laser bias (x4 lanes for QSFP). That's 5-14 data points for one DOM read. With the cached path, I can invalidate the cache to trigger a read, then read each of those 14 keys (cached). The buffer gets filled once (the data is dynamic, so I need that refresh), then the remaining reads all use the same buffer data. The data is also consistent this way, with all of the keys gathered at the same time. The original issue here is that the code is redundant. If I collapse those two routines together, then any changes in the future will only need to be made once, reducing the chance of fixing one and forgetting the other. |
No description provided.
The text was updated successfully, but these errors were encountered: