Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3-to-dc glob error #167

Open
kieranricardo opened this issue Mar 16, 2021 · 1 comment
Open

s3-to-dc glob error #167

kieranricardo opened this issue Mar 16, 2021 · 1 comment

Comments

@kieranricardo
Copy link
Contributor

kieranricardo commented Mar 16, 2021

s3-to-dc can't parse glob urls like s3://dea-public-data/fractional-cover/fc-percentile/annual/v2.2.0/combined/**/2020/*.yaml. It seems like specify a subfolder after the * or ** patterns causes parse_query to throw:

ValueError: Bad query: ...
@Kirill888
Copy link
Member

not supported currently, /**/ stands for any number of sub-folders, and only allow this to be followed by "file pattern", so ../**/<file-pattern>.

I feel we should probably just support arbitrary grep patterns instead, but then you still need to list all the paths (slow) and then discard those that do not match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants