Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Add Django 4.2 in CI #1488

Closed
iamsobanjaved opened this issue Aug 30, 2023 · 3 comments
Closed

Add Django 4.2 in CI #1488

iamsobanjaved opened this issue Aug 30, 2023 · 3 comments
Assignees

Comments

@iamsobanjaved
Copy link
Contributor

iamsobanjaved commented Aug 30, 2023

In order to have support for Django 4.2, we first need to run tests on Django 4.2 in the insights service. For updating CI, we should run tox and GitHub actions modernizers.

Tox Modernizer: tox_moderniser_django42.py

Github Action Modernizer: github_actions_modernizer_django42.py

### A/C
- [x] Run tests with Django 4.2
- [x] Fix all test failures with Django 4.2 (if any)
- [ ] After merging, ask the owning squad to add Django 4.2 tests in branch protection rules
@UsamaSadiq UsamaSadiq self-assigned this Sep 14, 2023
@UsamaSadiq
Copy link
Contributor

Created PR #1498 to fix the deprecations needed for Django 4.2 tests.

@UsamaSadiq
Copy link
Contributor

CI checks are currently not running in the repo. To verify the Django 4.2 upgrade, we need to enable the CI checks first.

@UsamaSadiq
Copy link
Contributor

For Django 4.2 upgrade, we need new version of pinax-announcements==4.0.1 with the fix for django.conf.urls. The PR for this fix has already been created against the upstream package and issue has been created with no response from the package maintainers. pinax/pinax-announcements#74.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants