Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate and resolve optimizely-sdk constraint #34103

Open
UsamaSadiq opened this issue Jan 24, 2024 · 1 comment
Open

Investigate and resolve optimizely-sdk constraint #34103

UsamaSadiq opened this issue Jan 24, 2024 · 1 comment
Assignees

Comments

@UsamaSadiq
Copy link
Member

Description

  • optimizely-sdk==5.0.0 started breaking tests [ common/djangoapp/tests/test_views.py::SAMLMetadataTest::test_secure_key_configuration ]
  • The package was pinned in the PR to resolve the test failures.
  • Investigate the underlying reason, fix and remove the constraint.
@robrap
Copy link
Contributor

robrap commented Jan 24, 2024

@jristau1984: I want to bring this ticket to your attention, because it brings up interesting issues:

  1. If we don't maintain edx-platform, Axim may wish to pull out 2U specific dependencies. See https://github.com/openedx/edx-platform/blob/master/requirements/edx/bundled.in
  2. As we potentially move more dependencies to be private dependencies, we don't have a great upgrade story for these private dependencies. I think this may be ticketed somewhere, but I'm not sure. And as can be seen by this ticket, how and where will we run tests with our dependencies?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants