docs: upstream block ADR, take 2 #35421
Conversation
kdmccormick
force-pushed
the
kdmccormick/upstream2
branch
from
2bd86b3
to
074901c
Compare
|
@ormsbee @bradenmacdonald This is an updated take on my first upstream_block ADR, plus what I learned from actually implementing it, plus a new approach for limited customizability of downstream blocks. |
| """ | ||
| ... | ||
|
|
||
| def sync_from_upstream(self, *, user: User, apply_updates: bool) -> None: |
There was a problem hiding this comment.
same here, I think these should be moved elsewhere or at least marked as @final
| """), | ||
| default=None, scope=Scope.settings, hidden=True, enforce_type=True, | ||
| ) | ||
| downstream_customized = List( |
There was a problem hiding this comment.
Maybe Set instead of List here?
kdmccormick
force-pushed
the
kdmccormick/upstream2
branch
2 times, most recently
from
5cb9ecb
to
1dd016e
Compare
kdmccormick
force-pushed
the
kdmccormick/upstream2
branch
from
1dd016e
to
3872f14
Compare
|
@bradenmacdonald @ormsbee This is ready for re-review. |
|
@bradenmacdonald Did you want to make another pass before I merge? |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Fully rendered ADR: https://github.com/kdmccormick/edx-platform/blob/kdmccormick/upstream2/docs/decisions/0020-upstream-downstream.rst