build: make pip_requirements a prereq for production-requirements #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to deploy enterprise-subsidy using a Ansible playbook based on the edx_django_service role, the production requirements fail to install as the pip-tools are missing. This commit makes installing pip-tools a prereq for install production-requirements.
|
Thanks for the pull request, @tecoholic! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
openedx-webhooks
added
the
open-source-contribution
Agrendalath
approved these changes
Feb 19, 2024
|
Hi @dianakhuang, can kindly you give this a quick review? |
dianakhuang
approved these changes
Jun 25, 2024
|
technically not an owner of this repo, but it seems fine |
|
@tecoholic 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
@dianakhuang Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When trying to deploy enterprise-subsidy using a Ansible playbook based on the edx_django_service role - openedx-unsupported/configuration#7107, the production requirements fail to install as the pip-tools are missing. This commit makes installing pip-tools a prereq for install production-requirements.
Testing instructions
Running
make production-requirementsafter a fresh clone completes without fail.Merge checklist