Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: zero state card and invite modal #1249

Merged
merged 3 commits into from
Jun 7, 2024
Merged

Conversation

katrinan029
Copy link
Contributor

@katrinan029 katrinan029 commented Jun 5, 2024

Description

  1. For groups that apply to all contexts, we will hide the zero state card with the "Get started" or "invite new members" button, we also shouldn't show this card to budgets that are expired.
  2. For the invite modal email address overflow, set the limit to 15 instead of 14 email addresses.
    https://2u-internal.atlassian.net/browse/ENT-9022

UI updates

before after
Screenshot 2024-06-05 at 1 36 44 PM Screenshot 2024-05-29 at 10 20 10 AM
Screenshot 2024-06-05 at 1 41 24 PM Screenshot 2024-06-05 at 1 40 12 PM

Test plan

Follow these steps to test/verify the changes to the invite modal:

  1. git fetch
  2. git checkout knguyen2/ent-9022
  3. vist link https://localhost.stage.edx.org:1991/exec-ed-2u-integration-qa/admin/learner-credit/92fa52bc-6863-49ff-8a32-1cfefbfbb728
  4. click on button labeled New Members
  5. copy and paste the emails below into the email address box.
    [email protected]
    [email protected]
    [email protected]
    [email protected]
    [email protected]
    [email protected]
    [email protected]
    [email protected]
    [email protected]
    [email protected]
    [email protected]
    [email protected]
    [email protected]
    [email protected]
    [email protected]
    [email protected]
  6. confirm in the summary tab that you are able to see the last email being [email protected] and clicking Show more will display [email protected]
  7. repeat steps 4 - 5 on stage link https://portal.stage.edx.org/exec-ed-2u-integration-qa/admin/learner-credit/92fa52bc-6863-49ff-8a32-1cfefbfbb728 and confirm that only 14 emails are shown instead of 15 and clicking Show more renders 2 additional emails instead of 1.

Follow the these steps to test/verify the changes to the Browse and Enroll zero state card for groups that apply to all contexts:

  1. visit link with budget that is tied to a group that has apply to all contexts enabled: https://localhost.stage.edx.org:1991/pawnee-parks/admin/learner-credit/6acd1860-d0a5-4e35-a529-5b3dd589c1db
  2. confirm that the empty spent table is rendered in place of the zero state card as seen in the UI changes section.
  3. to verify the changes between stage and dev, visit https://portal.stage.edx.org/pawnee-parks/admin/learner-credit/6acd1860-d0a5-4e35-a529-5b3dd589c1db and confirm that the zero state card is rendered instead of the empty spent table.

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.32%. Comparing base (8ef903d) to head (fde44b7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1249   +/-   ##
=======================================
  Coverage   85.32%   85.32%           
=======================================
  Files         538      538           
  Lines       11858    11860    +2     
  Branches     2526     2534    +8     
=======================================
+ Hits        10118    10120    +2     
  Misses       1681     1681           
  Partials       59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kiram15 kiram15 self-requested a review June 6, 2024 18:16
Copy link
Contributor

@kiram15 kiram15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@katrinan029 katrinan029 merged commit e9b406f into master Jun 7, 2024
6 checks passed
@katrinan029 katrinan029 deleted the knguyen2/ent-9022 branch June 7, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants