advance analytics plotly chart components #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muhammad-ammar
force-pushed
the
ammar/advance-analytics-plotly-chart-components
branch
from
ff6026b
to
d708471
Compare
muhammad-ammar
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1266 +/- ##
==========================================
+ Coverage 85.41% 85.43% +0.01%
==========================================
Files 542 554 +12
Lines 11991 12081 +90
Branches 2525 2567 +42
==========================================
+ Hits 10242 10321 +79
- Misses 1691 1701 +10
- Partials 58 59 +1 ☔ View full report in Codecov by Sentry. |
muhammad-ammar
force-pushed
the
ammar/advance-analytics-plotly-chart-components
branch
2 times, most recently
from
4adbdb5
to
275e827
Compare
muhammad-ammar
requested review from
saleem-latif,
mahamakifdar19,
jajjibhai008 and
irfanuddinahmad
saleem-latif
approved these changes
Jul 26, 2024
|
|
||
| const AnalyticsV2Page = () => { | ||
| const [activeTab, setActiveTab] = useState('enrollments'); | ||
| const [granularity, setGranularity] = useState(undefined); |
There was a problem hiding this comment.
It would be better to have the default value here instead of undefined.
| const AnalyticsV2Page = () => { | ||
| const [activeTab, setActiveTab] = useState('enrollments'); | ||
| const [granularity, setGranularity] = useState(undefined); | ||
| const [calculation, setCalculation] = useState(undefined); |
|
@muhammad-ammar Please attach screenshots in the PR description. |
mahamakifdar19
approved these changes
Jul 26, 2024
jajjibhai008
requested changes
Jul 29, 2024
| <div className="container-fluid w-100"> | ||
| <div className="row data-refresh-msg-container mb-4"> | ||
| <div className="col"> | ||
| <span>Data updated on ...</span> |
There was a problem hiding this comment.
Please mark the static strings for translations.
| <div className="row filter-container mb-4"> | ||
| <div className="col"> | ||
| <Form.Group> | ||
| <Form.Label>Start Date</Form.Label> |
There was a problem hiding this comment.
Please mark the static strings for translations.
|
jajjibhai008
approved these changes
Jul 29, 2024
muhammad-ammar
force-pushed
the
ammar/advance-analytics-plotly-chart-components
branch
from
cc5c2f9
to
cabb37c
Compare
muhammad-ammar
deleted the
ammar/advance-analytics-plotly-chart-components
branch
muhammad-ammar
added
the
plotly-migration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA:
Screenshot:
For all changes
Only if submitting a visual change