Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design tokens documentation #1546

Closed
2 tasks done
Tracked by #246
viktorrusakov opened this issue Aug 12, 2022 · 7 comments · Fixed by #1623
Closed
2 tasks done
Tracked by #246

Design tokens documentation #1546

viktorrusakov opened this issue Aug 12, 2022 · 7 comments · Fixed by #1623
Assignees
Labels
engineering Engineering epic Large unit of work, consisting of multiple tasks raccoon-gang

Comments

@viktorrusakov
Copy link
Contributor

viktorrusakov commented Aug 12, 2022

AC

PRs

@viktorrusakov viktorrusakov added this to the Design tokens with style-dictionary milestone Aug 12, 2022
@monteri monteri linked a pull request Sep 13, 2022 that will close this issue
10 tasks
@arbrandes
Copy link
Contributor

Community project manager check: I see the PR was merged. Anything else that needs doing?

@viktorrusakov
Copy link
Contributor Author

@arbrandes Yeah, I don't think that PR was enough, that was just an initial documentation that we'll need to improve on (probably in follow-up issues). As for this issue - I'd like us to create a proper ADR related to design tokens first, we will close this issue once it gets merged, hopefully this or next week 🙂

@arbrandes
Copy link
Contributor

@viktorrusakov, sprint check: got any updates for us? Thanks!

@viktorrusakov
Copy link
Contributor Author

@arbrandes not much for now, honestly this just escaped our radar 😞. But @adamstankiewicz is planning to create open a PR with the ADR this week, then it will be just a question of reviewing / merging.

@arbrandes
Copy link
Contributor

Linking to ADR for future reference:

#1929

@adamstankiewicz adamstankiewicz added the engineering Engineering label Jan 24, 2023
@viktorrusakov
Copy link
Contributor Author

this one is also related: #1905

@arbrandes arbrandes added the epic Large unit of work, consisting of multiple tasks label Feb 6, 2023
@arbrandes
Copy link
Contributor

I think we can call this done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering Engineering epic Large unit of work, consisting of multiple tasks raccoon-gang
Projects
Status: Closed
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants