Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Previously supported custom parameters not passing validation #410

Open
alangsto opened this issue Sep 20, 2023 · 2 comments
Open

Previously supported custom parameters not passing validation #410

alangsto opened this issue Sep 20, 2023 · 2 comments
Labels
bug Report of or fix for something that isn't working as intended

Comments

@alangsto
Copy link
Contributor

#392 introduced a breaking change that prevents previously allowed custom parameters from passing validation.

Example of custom parameter that now does not pass validation:

["next=something?repo=https://github.com/org/repo?folder=/home/user&branch=main"]

Changes to the custom parameter validation should be backwards compatible, and account for cases like this where the user passes in a single string.

@alangsto alangsto changed the title Previously supported parameters not passing validation Previously supported custom parameters not passing validation Sep 20, 2023
@alangsto
Copy link
Contributor Author

@kuipumu tagging you as the author of #392.

@jmakowski1123 jmakowski1123 added the bug Report of or fix for something that isn't working as intended label Sep 21, 2023
@kuipumu
Copy link
Contributor

kuipumu commented Sep 27, 2023

@alangsto I created a PR that should address this issue #412, this should be loose enough to allow any kind on key-pair value has a custom parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report of or fix for something that isn't working as intended
Projects
Status: Backlog
Development

No branches or pull requests

3 participants