Skip to content

Commit

Permalink
ufw: Fix "could not find required binary 'iptables'"
Browse files Browse the repository at this point in the history
Switch from using DISTUTILS_*_ARGS to SETUPTOOLS_*_ARGS to correspond
with the earlier change to use setuptools3_legacy instead of distutils3.

Without this change, you will get the following error if your build host
does not have iptables installed:

Fixes:
  ERROR: ufw-0.36.1-r0 do_compile: 'python3 setup.py build ' execution failed.
  Log data follows:
  | DEBUG: Executing shell function do_compile
  | ERROR: could not find required binary 'iptables'
  | ERROR: 'python3 setup.py build ' execution failed.
  | WARNING: exit code 1 from a shell command.
  ERROR: Task ([snip]/meta-openembedded/meta-networking/recipes-connectivity/ufw/ufw_0.36.1.bb:do_compile) failed with exit code '1'

Also, although the build will not fail on a host that has iptables, it
could cause a problem if it is installed at a different path than where
OpenEmbedded's iptables will be installed on the target.

Fixes: 3e2ed1d ("ufw: port to setuptools, use setuptools_legacy")
Signed-off-by: Howard Cochran <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
  • Loading branch information
Howard Cochran authored and kraj committed Sep 15, 2022
1 parent 2659f3d commit 63fd43b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions meta-networking/recipes-connectivity/ufw/ufw_0.36.1.bb
Original file line number Diff line number Diff line change
Expand Up @@ -70,5 +70,5 @@ FILES:${PN} += " \

REQUIRED_DISTRO_FEATURES = "ipv6"

DISTUTILS_BUILD_ARGS:append = " --iptables-dir /usr/sbin"
DISTUTILS_INSTALL_ARGS:append = " --iptables-dir /usr/sbin"
SETUPTOOLS_BUILD_ARGS:append = " --iptables-dir /usr/sbin"
SETUPTOOLS_INSTALL_ARGS:append = " --iptables-dir /usr/sbin"

0 comments on commit 63fd43b

Please sign in to comment.