Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ufw: Fix "could not find required binary 'iptables'" #609

Conversation

howardcochran
Copy link

Switch from using DISTUTILS_ARGS to SETUPTOOLS_ARGS to correspond with the earlier change to use setuptools3_legacy instead of distutils3.

Without this change, you will get the following error if your build host does not have iptables installed:

Fixes:
ERROR: ufw-0.36.1-r0 do_compile: 'python3 setup.py build ' execution failed.
Log data follows:
| DEBUG: Executing shell function do_compile
| ERROR: could not find required binary 'iptables'
| ERROR: 'python3 setup.py build ' execution failed.
| WARNING: exit code 1 from a shell command.
ERROR: Task ([snip]/meta-openembedded/meta-networking/recipes-connectivity/ufw/ufw_0.36.1.bb:do_compile) failed with exit code '1'

Also, although the build will not fail on a host that has iptables, it could cause a problem if it is installed at a different path than where OpenEmbedded's iptables will be installed on the target.

Fixes: 3e2ed1d ("ufw: port to setuptools, use setuptools_legacy")
Signed-off-by: Howard Cochran [email protected]

Switch from using DISTUTILS_*_ARGS to SETUPTOOLS_*_ARGS to correspond
with the earlier change to use setuptools3_legacy instead of distutils3.

Without this change, you will get the following error if your build host
does not have iptables installed:

Fixes:
  ERROR: ufw-0.36.1-r0 do_compile: 'python3 setup.py build ' execution failed.
  Log data follows:
  | DEBUG: Executing shell function do_compile
  | ERROR: could not find required binary 'iptables'
  | ERROR: 'python3 setup.py build ' execution failed.
  | WARNING: exit code 1 from a shell command.
  ERROR: Task ([snip]/meta-openembedded/meta-networking/recipes-connectivity/ufw/ufw_0.36.1.bb:do_compile) failed with exit code '1'

Also, although the build will not fail on a host that has iptables, it
could cause a problem if it is installed at a different path than where
OpenEmbedded's iptables will be installed on the target.

Fixes: 3e2ed1d ("ufw: port to setuptools, use setuptools_legacy")
Signed-off-by: Howard Cochran <[email protected]>
@akuster
Copy link
Contributor

akuster commented Sep 15, 2022

Once this hits master, I'll pick it up

@kraj
Copy link
Contributor

kraj commented Sep 23, 2022

@akuster its in master now with 63fd43b

@kraj
Copy link
Contributor

kraj commented Jan 4, 2023

applied to kirkstone with eeeec7d

@kraj kraj closed this Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants