Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

[json-tests] stReturnDataTest blockchain test failures #11074

Closed
dvdplm opened this issue Sep 20, 2019 · 1 comment
Closed

[json-tests] stReturnDataTest blockchain test failures #11074

dvdplm opened this issue Sep 20, 2019 · 1 comment
Labels
F4-tests 💻 Tests need fixing, improving or augmenting. P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible.

Comments

@dvdplm
Copy link
Collaborator

dvdplm commented Sep 20, 2019

After #11054 the following JSON tests fail in stReturnDataTest/ and are added to the list of skipped tests in ethcore/res/ethereum/tests-issues/currents.json.

"returndatasize_after_successful_callcode_d0g0v0_ConstantinopleFix"

Fix the tests and "un-skip" them.

Investigation

The issue here is about the genesis block not matching the test expectation. We end up with a genesis block with hash 0x3d3cd0c74d5040bd64c4077146499e075459c7facf999ebfcc2eac2bd81183e9 and the test block expects the parent hash to be 0x43dd448195341d2b9ff0683061d5003dfdef21c9dd5f9132c71df9982664a2d2 and so the block import fails with an UnknownParent error.
The genesis block is constructed using the state from the pre section of the test file. The state_root we calculate from this data, 0x66bfe5cd9198e024259b887599af885c4f03ec4925b854ddf8525c60f404068c, does not match what the test expects, 0x7c3eb449ede11443a1e9d714c211702d5f6e73d0c41f5af8936f9567ffde1a0f.

This is likely what causes the genesis blocks hash to be wrong (indeed, the genesisRLP from the test file is identical to spec.genesis_block().to_hex() except for the state_root).

This is most likely the same bug as #11075.

As far as I can tell we deserialize the data properly from disk.

@dvdplm dvdplm added F4-tests 💻 Tests need fixing, improving or augmenting. P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible. labels Sep 20, 2019
@ordian
Copy link
Collaborator

ordian commented Sep 23, 2019

Closed by #11083.

@ordian ordian closed this as completed Sep 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F4-tests 💻 Tests need fixing, improving or augmenting. P2-asap 🌊 No need to stop dead in your tracks, however issue should be addressed as soon as possible.
Projects
None yet
Development

No branches or pull requests

2 participants