Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

update_account_cache can't return error, but it should #9838

Closed
sorpaas opened this issue Oct 31, 2018 · 0 comments
Closed

update_account_cache can't return error, but it should #9838

sorpaas opened this issue Oct 31, 2018 · 0 comments
Labels
F5-task 🎬 Generic label for things that just have to get done but are no issues in first place. M4-core ⛓ Core client code / Rust.
Milestone
2.3

Comments

@sorpaas
Copy link
Collaborator

sorpaas commented Oct 31, 2018

https://github.com/paritytech/parity-ethereum/blob/39f25d20a84ab2b8931a75e28da90a9ccffcc893/ethcore/src/state/mod.rs#L1154

In this line, we're inside the RefMut wrapper. update_account_cache can fail in rare cases, but we didn't catch error and return it.
@sorpaas sorpaas added M4-core ⛓ Core client code / Rust. F5-task 🎬 Generic label for things that just have to get done but are no issues in first place. labels Oct 31, 2018
@5chdn 5chdn added this to the 2.3 milestone Nov 26, 2018
@sorpaas sorpaas mentioned this issue Nov 29, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
F5-task 🎬 Generic label for things that just have to get done but are no issues in first place. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
2.3
Development

No branches or pull requests
2 participants
@sorpaas @5chdn