New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove UI theme #30

Merged

rhamzeh merged 1 commit into main from chore/theme-fix

Sep 6, 2024

Collaborator

d-jeffery commented Jun 21, 2024 •

edited by rhamzeh

Loading

Description

openfgaintellijplugin-0.1.2.zip

Theme in VSCode Dark Modern:

References

fixes Use the standard tokens for the tokenizer #27

Review Checklist

I have clicked on "allow edits by maintainers".
I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
The correct base branch is being used, if not main
I have added tests to validate that the change in functionality is working as expected


          fix: remove UI theme

d3882f5

d-jeffery requested a review from rhamzeh

June 21, 2024 15:50

d-jeffery marked this pull request as ready for review

June 21, 2024 16:40

d-jeffery requested review from a team as code owners

June 21, 2024 16:40

ewanharris approved these changes

View reviewed changes

rhamzeh previously approved these changes

View reviewed changes

rhamzeh reviewed

View reviewed changes

Member

rhamzeh left a comment

@d-jeffery looks good - but the token for the condition in the type restrictions seems weird - why is it coloured differently in all the themes?

rhamzeh dismissed their stale review

June 26, 2024 14:00

Waiting for feedback

rhamzeh merged commit aa96ae1 into main

14 checks passed

rhamzeh deleted the chore/theme-fix branch

September 6, 2024 15:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet