Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add RSS feed link in header and footer #532

Closed
wants to merge 1 commit into from

Conversation

adriantam
Copy link
Member

@adriantam adriantam commented Oct 16, 2023

Description

Adding RSS feed to header to footer.
Screenshot 2023-10-16 at 10 18 43 AM

Screen.Recording.2023-10-16.at.10.18.53.AM.mov

References

Close #531
Image Source: https://iconduck.com/sets/font-awesome-icons

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@adriantam adriantam requested a review from a team as a code owner October 16, 2023 14:22
@rhamzeh
Copy link
Member

rhamzeh commented Oct 16, 2023

Maybe the footer alone would be enough?

The header is already crowded. And as much as I love and use RSS, I don't believe as many people use it as to warrant being as prominently featured when we already have so little space available.

What do you think @matthewpereira @aaguiarz ?

@Siddhant-K-code
Copy link
Contributor

The header is already crowded

I think, having RSS feed logo in the footer is sufficient. And, we can also directly link on /blog page:

image image image

@rhamzeh rhamzeh marked this pull request as draft January 2, 2024 14:46
@rhamzeh
Copy link
Member

rhamzeh commented Jan 2, 2024

@adriantam @aaguiarz @matthewpereira anything we want to do with this one?

@adriantam
Copy link
Member Author

Close for now

@adriantam adriantam closed this Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add blog RSS feed to header and footer
3 participants