From 75992723086c5a1ae08c142cc8b366a10f4bd803 Mon Sep 17 00:00:00 2001 From: dipietroR <66142242+dipietroR@users.noreply.github.com> Date: Fri, 22 Jul 2022 12:35:33 -0400 Subject: [PATCH] feat: uncommenting severity 4 rules in `.perlcriticrc` (#7109) feat: uncommenting severity 4 rules in .perlcriticrc --- .perlcriticrc | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/.perlcriticrc b/.perlcriticrc index 58857ef418ba1..1fa97c97a80b3 100644 --- a/.perlcriticrc +++ b/.perlcriticrc @@ -38,16 +38,19 @@ equivalent_modules = ProductOpener::PerlStandards # severity 4 was not actually being run because severity was set to 5. -# severity 4: -#[TestingAndDebugging::RequireUseWarnings] -#equivalent_modules = Modern::Perl +# severity 4 +[TestingAndDebugging::RequireUseWarnings] +equivalent_modules = Modern::Perl +equivalent_modules = ProductOpener::PerlStandards +[Subroutines::RequireFinalReturn] + [BuiltinFunctions::RequireBlockMap] [BuiltinFunctions::RequireBlockGrep] # Allow `$`', `$&', `$'', because since Perl 5.20.0 # there are no performance implications any more. -#[-Variables::ProhibitMatchVars] +[-Variables::ProhibitMatchVars] # /end severity 4