Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove warning in KnowledgePanelsReportProblem.pm, remove report problem card from pro platform #10112

Merged
merged 4 commits into from
Apr 9, 2024

Conversation

stephanegigandet
Copy link
Contributor

Removes a warning that $panel_data_ref is redeclared

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a simple link to signalconso in addition to the one on the image ? It should work for tomorrow

@stephanegigandet stephanegigandet enabled auto-merge (squash) April 9, 2024 15:19
@github-actions github-actions bot added 🧪 tests 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. labels Apr 9, 2024
@stephanegigandet stephanegigandet changed the title fix: remove warning in KnowledgePanelsReportProblem.pm fix: remove warning in KnowledgePanelsReportProblem.pm, remove report problem card from pro platform Apr 9, 2024
Copy link

sonarcloud bot commented Apr 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@stephanegigandet stephanegigandet enabled auto-merge (squash) April 9, 2024 15:59
@stephanegigandet stephanegigandet merged commit 7108cae into main Apr 9, 2024
13 checks passed
@stephanegigandet stephanegigandet deleted the signalconso-fix2 branch April 9, 2024 16:30
john-gom pushed a commit that referenced this pull request May 24, 2024
… problem card from pro platform (#10112)

* fix: remove warning in KnowledgePanelsReportProblem.pm

* add link

* update tests

* no report_problem card on pro platform
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels Product Page Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. 🧪 tests
Projects
Development

Successfully merging this pull request may close these issues.

2 participants