Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve rate-limiter #10338

Merged
merged 4 commits into from
May 23, 2024
Merged

feat: improve rate-limiter #10338

merged 4 commits into from
May 23, 2024

Conversation

raphael0202
Copy link
Contributor

@raphael0202 raphael0202 commented May 22, 2024 •
edited
Loading

  • save rate-limiter logs in a separate file, so that we can quickly know if a user is blocked (or would have been blocked if RATE_LIMITER_BLOCKING_ENABLED=0)
  • add an allow list of IP addresses we don't want to block. Only OVH2 IP address is part of this list for now.

@github-actions github-actions bot added GitHub Actions Pull requests that update Github_actions code REDIS Display labels May 22, 2024
@raphael0202 raphael0202 changed the title fix: save rate limiter logs in separate log file feat: improve rate-limiter May 23, 2024
@raphael0202 raphael0202 marked this pull request as ready for review May 23, 2024 08:28
@raphael0202 raphael0202 requested a review from a team as a code owner May 23, 2024 08:28
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

stephanegigandet
stephanegigandet approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stephanegigandet stephanegigandet merged commit 52e0246 into main May 23, 2024
16 of 17 checks passed
@stephanegigandet stephanegigandet deleted the improve-rate-limiter branch May 23, 2024 09:23
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request May 23, 2024
Merged
john-gom pushed a commit that referenced this pull request May 24, 2024
@raphael0202 @john-gom
feat: improve rate-limiter (#10338)
37519aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanegigandet stephanegigandet stephanegigandet approved these changes

Assignees

@raphael0202 raphael0202

Labels
config Display GitHub Actions Pull requests that update Github_actions code REDIS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raphael0202 @stephanegigandet