Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: warnings modperl error log #10352

Merged
merged 2 commits into from
May 31, 2024
Merged

fix: warnings modperl error log #10352

merged 2 commits into from
May 31, 2024

Conversation

benbenben2
Copy link
Collaborator

What

Similar to #10344.
Trying to prevent warnings in logs.

@benbenben2 benbenben2 self-assigned this May 26, 2024
@benbenben2 benbenben2 requested a review from a team as a code owner May 26, 2024 12:41
@github-actions github-actions bot added 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. 🌱 Eco-Score https://world.openfoodfacts.org/eco-score-the-environmental-impact-of-food-products 📍 Origins Origins are used for Eco-Score computation. We want to have structured origins. Display Attributes https://wiki.openfoodfacts.org/Product_Attributes 🥗 Ingredients labels May 26, 2024
alexgarel
alexgarel approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool ! Only spotted a typo !

lib/ProductOpener/Display.pm Outdated Show resolved Hide resolved
@alexgarel alexgarel enabled auto-merge (squash) May 31, 2024 06:35
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 31, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@alexgarel alexgarel merged commit e32c891 into main May 31, 2024
12 checks passed
@alexgarel alexgarel deleted the fix_wanings_modperl_error_log_2 branch May 31, 2024 07:09
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request May 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

Assignees

@benbenben2 benbenben2

Labels
Attributes https://wiki.openfoodfacts.org/Product_Attributes Display 🌱 Eco-Score https://world.openfoodfacts.org/eco-score-the-environmental-impact-of-food-products 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis 🥗 Ingredients 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels logs 📍 Origins Origins are used for Eco-Score computation. We want to have structured origins. Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes.
Projects
Ingredient analysis
Status: Done
📖 Knowledge panels
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benbenben2 @alexgarel