Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display orgs data in table #10433

Conversation

TheSussex
Copy link
Collaborator

@TheSussex TheSussex commented Jun 11, 2024

What

Display a table that lists all organizations + some data about them (e.g. verified status, creation date, last update date etc.)

Screenshot

Screenshot 2024-06-12 at 3 08 58 PM

@github-actions github-actions bot added the Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. label Jun 11, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.51%. Comparing base (dc04d18) to head (0d7255c).
Report is 411 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10433      +/-   ##
==========================================
- Coverage   49.54%   49.51%   -0.04%     
==========================================
  Files          67       75       +8     
  Lines       20650    21573     +923     
  Branches     4980     5175     +195     
==========================================
+ Hits        10231    10681     +450     
- Misses       9131     9582     +451     
- Partials     1288     1310      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the 💥 Merge Conflicts 💥 Merge Conflicts label Jun 12, 2024
@TheSussex TheSussex marked this pull request as ready for review June 12, 2024 12:43
@TheSussex TheSussex requested a review from a team as a code owner June 12, 2024 12:43
@github-actions github-actions bot removed the 💥 Merge Conflicts 💥 Merge Conflicts label Jun 13, 2024
Copy link

sonarcloud bot commented Jun 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions github-actions bot added the 💥 Merge Conflicts 💥 Merge Conflicts label Jun 17, 2024
@stephanegigandet
Copy link
Contributor

@TheSussex I'm not sure why, but the failing test is probably due to the new "Creator" string that somehow mixes with the contributors tag type. I can't reproduce it locally though.

Could you change the "creator" / "Creator" string by "created_by" / "Created by"? I think it will solve the test issue.

@github-actions github-actions bot removed the 💥 Merge Conflicts 💥 Merge Conflicts label Jun 20, 2024
@stephanegigandet
Copy link
Contributor

Merging as is, further changes can be done in a future PR.

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Merging as is, further changes can be done in a future PR.

@stephanegigandet stephanegigandet merged commit 5dcb329 into openfoodfacts:main Jun 21, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. 🌐 Translations
Projects
Development

Successfully merging this pull request may close these issues.

Display a table that lists all organizations + some data about them
3 participants