Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use a separate make target for production up to not create dependencies #10480

Merged
merged 5 commits into from
Jun 21, 2024

Conversation

john-gom
Copy link
Contributor

What

Use a different target for docker compose up in production so that dependencies aren't also started in dev mode.

@john-gom john-gom requested a review from a team as a code owner June 21, 2024 14:15
@github-actions github-actions bot added the GitHub Actions Pull requests that update Github_actions code label Jun 21, 2024
Signed-off-by: John Gomersall <[email protected]>
@github-actions github-actions bot added the 🐋 Docker https://docker-curriculum.com/ label Jun 21, 2024
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: John Gomersall <[email protected]>
Signed-off-by: John Gomersall <[email protected]>
Signed-off-by: John Gomersall <[email protected]>
Copy link

sonarcloud bot commented Jun 21, 2024

@john-gom john-gom merged commit a49e5fb into main Jun 21, 2024
12 checks passed
@john-gom john-gom deleted the shared-services-2 branch June 21, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐋 Docker https://docker-curriculum.com/ GitHub Actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants