-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove "report problem" in the navigation bar if knowledge panel is not present #10484
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10484 +/- ##
==========================================
- Coverage 49.54% 49.31% -0.24%
==========================================
Files 67 76 +9
Lines 20650 21838 +1188
Branches 4980 5231 +251
==========================================
+ Hits 10231 10769 +538
- Misses 9131 9750 +619
- Partials 1288 1319 +31 ☔ View full report in Codecov by Sentry. |
Hi @subi9 , some of the tests results changed (just some new lines), could you run "make update_tests_results" to update the test results and commit the new results? |
Head branch was pushed to by a user without write access
Hi @stephanegigandet , I have executed the "make update_tests_results" and then committed the results.Please approve if this looks good. |
@@ -1,7 +1,7 @@ | |||
<!-- start templates/web/common/site_layout.tt.html --> | |||
|
|||
<!doctype html> | |||
<html class="no-js" lang="en" data-serverdomain="openfoodfacts.localhost" dir="ltr"> | |||
<html class="no-js" lang="en" data-serverdomain="pro.openfoodfacts.localhost" dir="ltr"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@subi9 I forgot to tell you that "make update_tests_results" should be run in the normal "off" environment, not "off-pro", otherwise the test results are different. Could you rerun it again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stephanegigandet I have re executed the test results in the normal "off" environment. Can you please check and approve.
"Report problem" navigation bar is removed if the corresponding knowledge panel is not present.Screenshot attached
Screenshot