fix: use allow_non_ref in JSON decoding of off-query #10587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
alexgarel
approved these changes
Jul 23, 2024
alexgarel
pushed a commit
that referenced
this pull request
Jul 24, 2024
🤖 I have created a release *beep* *boop* --- ## [2.38.1](v2.38.0...v2.38.1) (2024-07-24) ### Bug Fixes * be consistent in regexp for props matching ([#10579](#10579)) ([7f1d4ba](7f1d4ba)) * important fix in routing ([#10590](#10590)) ([2106bef](2106bef)) * org name input field not displaying when checkbox is checked in pro pl… ([#10588](#10588)) ([9dfcf29](9dfcf29)) * use allow_non_ref in JSON decoding of off-query ([#10587](#10587)) ([1a8e82b](1a8e82b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently switched from JSON::PP to Cpanel::JSON::XS, and it looks like JSON::PP decode_json() was accepting to decode raw numbers, without having to specify allow_non_ref.
We had an issue when trying to deploy to prod, because on count requests, the return value we get from off-query is a raw number, which could not get decoded:
[2024/07/23 15:28:00] /srv/off/lib/ProductOpener/Display.pm 5369 ProductOpener.Display {error => '
JSON text must be an object or array (but found number, string, true, false or null, use allow_non
ref to allow this) at /srv/off/lib/ProductOpener/Data.pm line 140. ',request => 'qwfXeMshf0b7OpAF'
,tags => [{canon_tagid => 'en:canadaschtroumpf',display_tag => 'Canadaschtroumpf',new_tagid => 'en
:canadaschtroumpf',new_tagid_path => '/country/canadaschtroumpf',tag => 'en:canadaschtroumpf',tag_
prefix => '',tagid => 'en:canadaschtroumpf',tagtype => 'countries',tagtype_name => 'country',tagty
pe_path => '/countries'}]} MongoDB error