Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Determine obsolete and deleted from the product revision #10791

Conversation

john-gom
Copy link
Contributor

Signed-off-by: John Gomersall [email protected]

What

Use the product revision to determine delete and obsolete status

…historic-events-into-off-query-doesnt-recognise-deleted-products
Signed-off-by: John Gomersall <[email protected]>
Copy link

sonarcloud bot commented Sep 13, 2024

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you

@stephanegigandet stephanegigandet merged commit 508d767 into main Sep 13, 2024
12 checks passed
@stephanegigandet stephanegigandet deleted the 10789-script-to-load-historic-events-into-off-query-doesnt-recognise-deleted-products branch September 13, 2024 13:06
stephanegigandet pushed a commit that referenced this pull request Oct 2, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.45.0](v2.44.0...v2.45.0)
(2024-10-02)


### Features

* Add short name, value and evaluation to knowledge panels
([#9683](#9683))
([bb5c3e2](bb5c3e2))
* enable attributes / personal search on OBF, OPF, OPFF, new config +
logos for OPF & OPFF
([#10757](#10757))
([7e25d9a](7e25d9a))
* make improvements to org table
([#10679](#10679))
([b0cfea1](b0cfea1))
* Small fixes + improvements
([#10818](#10818))
([bd91419](bd91419))


### Bug Fixes

* add Moji server IP to rate-limit allow-list
([#10785](#10785))
([065e0ab](065e0ab))
* add more nutrients to test, to test more things
([#10834](#10834))
([42b341d](42b341d))
* also check .pot GetText files in addition to .po files
([#10827](#10827))
([bb87197](bb87197))
* Determine obsolete and deleted from the product revision
([#10791](#10791))
([508d767](508d767))
* do not localize ecoscore on obf,opf,opff
([#10837](#10837))
([2f93877](2f93877))
* docs Adding closing ) to generate proper internal link
([#10850](#10850))
([492d6d9](492d6d9))
* docs Fixed proper denomination of product in query
([#10853](#10853))
([428dbb3](428dbb3))
* improve OCR JSON generation script
([#10802](#10802))
([3e8fee7](3e8fee7))
* incorrect self-reference in ingredient.yaml
([#10786](#10786))
([2757699](2757699))
* indicate some attributes have only mandatory / not_important options
([#10846](#10846))
([258dc8f](258dc8f))
* invalid type in product_misc.yaml
([#10787](#10787))
([21920a1](21920a1))
* new mongodb exports for obsolete products collection
([#10794](#10794))
([c22fc42](c22fc42))
* permissions for check-translations.sh
([#10838](#10838))
([62e12d6](62e12d6))
* YAML syntax in schema files.
([#10783](#10783))
([959c74c](959c74c))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Script to load historic events into off-query doesn't recognise deleted products
2 participants