Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevention - Create edit rule for "Loading…" #4362

Open
Tracked by #10272
teolemon opened this issue Oct 14, 2020 · 4 comments
Open
Tracked by #10272

Prevention - Create edit rule for "Loading…" #4362

teolemon opened this issue Oct 14, 2020 · 4 comments
Labels
Data destroying issue This issue relates to an on-going issue actively destroying product data ! 🧽 Data quality - Prevention - Edit rules Edit Rules prevent quality issues by selectively ignoring or altering specific edits 🧽 Data quality https://wiki.openfoodfacts.org/Quality ⏲️ 5 minute fix

Comments

@teolemon
Copy link
Member

teolemon commented Oct 14, 2020

What

  • It seems that the "Loading…" issue is still around. Create edit rule for "Loading…" "Chargement…" to ignore the change to product_name_*

"Loading…"
"Chargement…"
"Caricamento…"

https://fr.openfoodfacts.org/produit/3245270000733/chargement-la-tourangelle

Part of

@teolemon teolemon added the 🐛 bug This is a bug, not a feature request. label Oct 14, 2020
@svensven
Copy link
Contributor

@teolemon teolemon added 🧽 Data quality - Prevention - Edit rules Edit Rules prevent quality issues by selectively ignoring or altering specific edits Data destroying issue This issue relates to an on-going issue actively destroying product data ! labels Nov 1, 2020
@github-actions github-actions bot added the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label Feb 2, 2021
@CharlesNepote
Copy link
Member

$ zcat openfoodfacts-products.jsonl.gz | jq -r '. | select(.product_name == ("Loading…","Loading...","Chargement…","Chargement...","Caricamento…","Caricamento...")) | [.code,.product_name,.last_modified_t] | @csv' > loading.csv
$ wc -l loading.csv 
223 loading.csv

There are many recent edits.

That said, 223 products is few. If this rule is not easy and quick to implement, I think we should forget it.

@github-actions github-actions bot removed the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label May 13, 2021
@teolemon teolemon added the 🧽 Data quality https://wiki.openfoodfacts.org/Quality label Jul 19, 2021
@teolemon teolemon changed the title Create edit rule for "Loading…" Prevention - Create edit rule for "Loading…" Oct 11, 2021
@github-actions github-actions bot added the ⭐ 🐛 top bug Top bug. label Nov 19, 2022
@github-actions github-actions bot removed the ⭐ 🐛 top bug Top bug. label May 3, 2023
@github-actions github-actions bot added the ⭐ 🐛 top bug Top bug. label Jul 18, 2023
@github-actions github-actions bot removed the ⭐ 🐛 top bug Top bug. label Jul 29, 2023
@github-actions github-actions bot added the ⭐ 🐛 top bug Top bug. label Aug 15, 2023
@github-actions github-actions bot removed the ⭐ 🐛 top bug Top bug. label Aug 29, 2023
@benbenben2
Copy link
Collaborator

is still around
Do you have a link to previous related bug?

313 products today
Mirabelle

@October-Food-Facts
Copy link

It still hasn't been fixed, in mid 2024.
https://pt.openfoodfacts.org/produto/20621483/a-carregar-crownfield?rev=196
They revert back the changes, so it will just be an edit war.

https://wiki.openfoodfacts.org/Data_quality_missions#Dealing_with_the_consequences_of_an_old_Android_bug

@teolemon teolemon removed the 🐛 bug This is a bug, not a feature request. label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Data destroying issue This issue relates to an on-going issue actively destroying product data ! 🧽 Data quality - Prevention - Edit rules Edit Rules prevent quality issues by selectively ignoring or altering specific edits 🧽 Data quality https://wiki.openfoodfacts.org/Quality ⏲️ 5 minute fix
Projects
Status: To discuss and validate
Status: To do
Development

No branches or pull requests

5 participants