Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quality - Prevention - Nutrition - Control _100g fields values as digits only #4582

Open
Tracked by #5538
ArchiMageAlex opened this issue Dec 4, 2020 · 4 comments
Open
Tracked by #5538
Labels
🧽 Data quality - Prevention 🧽 Data quality https://wiki.openfoodfacts.org/Quality ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it.

Comments

@ArchiMageAlex
Copy link

ArchiMageAlex commented Dec 4, 2020

Describe the bug
There are some values with _100g postfix contains underscores at start of value, that prevents of normal filtering and searching

Expected behavior
Values must be controlled at insert time or dynamically converted to numeric values with known issues like this.

Number of products impacted
dozens

@ArchiMageAlex ArchiMageAlex added the 🐛 bug This is a bug, not a feature request. label Dec 4, 2020
@ArchiMageAlex
Copy link
Author

I run check with my converter. There are errors in data:

Value of field fiber_100g, product code=0028400231053 contains underscore: _6.7
Value of field selenium_100g, product code=0032971251990 contains underscore: _0.000002
Value of field copper_100g, product code=0042400149927 contains underscore: _6.896552
Value of field fiber_100g, product code=0071828003108 contains underscore: _20
Value of field vitamin_a_100g, product code=0072392312726 contains underscore: _0.0003396
Value of field fiber_100g, product code=0614360000107 contains underscore: _1
Value of field proteins_100g, product code=04029816 contains underscore: _500
Value of field sugars_100g, product code=3161712000928 contains underscore: _0.1
Value of field fiber_100g, product code=7501024577057 contains underscore: _6.67
Value of field fiber_100g, product code=7501024577262 contains underscore: _1
Value of field fiber_100g, product code=7501024577286 contains underscore: _6.67
Value of field fiber_100g, product code=7501055904914 contains underscore: _0.417
Value of field fiber_100g, product code=7501055905072 contains underscore: _0.417
Value of field fiber_100g, product code=7501055905850 contains underscore: _0.4
Value of field fiber_100g, product code=7501055905942 contains underscore: _0.4
Value of field fiber_100g, product code=7501055905997 contains underscore: _0.417
Value of field sugars_100g, product code=7501069210759 contains underscore: _1
Value of field iron_100g, product code=8850649009290 contains underscore: _0.00026

@ArchiMageAlex ArchiMageAlex changed the title Control _kg fields values as digits only Control _100g fields values as digits only Dec 4, 2020
@stephanegigandet
Copy link
Contributor

That's interesting. It looks like someone tried to enter negative values:
https://fr.openfoodfacts.org/api/v0/produit/7501055905997/frutal-delactosado-sabor-fresa-alpura

@github-actions github-actions bot added the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label Mar 6, 2021
@teolemon teolemon added 🧽 Data quality https://wiki.openfoodfacts.org/Quality and removed ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. labels Jul 19, 2021
@teolemon
Copy link
Member

How widespread is the issue @ArchiMageAlex ?

@teolemon teolemon changed the title Control _100g fields values as digits only Quality Prevention - Nutrition - Control _100g fields values as digits only Oct 11, 2021
@teolemon teolemon changed the title Quality Prevention - Nutrition - Control _100g fields values as digits only Quality - Prevention - Nutrition - Control _100g fields values as digits only Oct 11, 2021
Copy link
Contributor

github-actions bot commented Feb 8, 2024

This issue has been open 90 days with no activity. Can you give it a little love by linking it to a parent issue, adding relevant labels and projets, creating a mockup if applicable, adding code pointers from https://github.com/openfoodfacts/openfoodfacts-server/blob/main/.github/labeler.yml, giving it a priority, editing the original issue to have a more comprehensive description… Thank you very much for your contribution to 🍊 Open Food Facts

@github-actions github-actions bot added the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label Feb 8, 2024
@teolemon teolemon removed the 🐛 bug This is a bug, not a feature request. label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧽 Data quality - Prevention 🧽 Data quality https://wiki.openfoodfacts.org/Quality ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it.
Projects
Status: To discuss and validate
Status: To do
Development

No branches or pull requests

3 participants