Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility [2.4.6]: Format visual headers in the footer as headings in the code #6535

Closed
Tracked by #4640
yuktea opened this issue Apr 1, 2022 · 0 comments · Fixed by #6546
Closed
Tracked by #4640

Accessibility [2.4.6]: Format visual headers in the footer as headings in the code #6535

yuktea opened this issue Apr 1, 2022 · 0 comments · Fixed by #6546
Assignees
@yuktea
Labels
accessibility ♿ Ensuring Open Food Facts is accessible to all 🐛 bug This is a bug, not a feature request. footer Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. 👍 Top 10 Issue!

Comments

@yuktea
Copy link
Contributor

yuktea commented Apr 1, 2022 •
edited
Loading

Describe the bug

This issue was reported by the Accessibility Foundation (#4640)
Quoting from Accessibility_report.pdf

2.4.6 Headings and Labels
In the footer there are 4 visual headers that are not formatted in the code as headings
with for example <h3> element. If you place the header in a <h3> element, the user can
6 scan your web page more easily.

To Reproduce

The footer at the bottom as 4 headings Open Food Facts

  • Install the app
  • Open Food Facts
  • Discover the project
  • Join the community

Expected behavior

In the code, these have not been formatted as headings which is the expected behavior to help users scan the page better. (Example: with an <h2> tag).

Screenshots

No response

Additional context

No response

Type of device

Browser

Browser version

No response

Number of products impacted

No response

Time per product

No response
@yuktea yuktea added the 🐛 bug This is a bug, not a feature request. label Apr 1, 2022
@teolemon teolemon added accessibility ♿ Ensuring Open Food Facts is accessible to all footer Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. labels Apr 1, 2022
@yuktea yuktea self-assigned this Apr 1, 2022
@yuktea yuktea mentioned this issue Apr 2, 2022
Merged
@teolemon teolemon mentioned this issue Jun 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuktea yuktea

Labels
accessibility ♿ Ensuring Open Food Facts is accessible to all 🐛 bug This is a bug, not a feature request. footer Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. 👍 Top 10 Issue!
Projects
♿️ Stellar Accessibility Across Open Food Facts
Archived in project
🍊 Open Food Facts Server issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Format footer titles as headings in code openfoodfacts/openfoodfacts-server
2 participants
@teolemon @yuktea