fix: Makes "Unselect Image" button translatable #6570
Conversation
github-actions
bot
added
Display
Translations
yuktea
changed the title
| msgctxt "unselect_image" | ||
| msgid "Unselect Image" | ||
| msgstr "" |
There was a problem hiding this comment.
@stephanegigandet to have the message at least in english if translation isn't available in target language,
isn't it better to repeat msgid in msgstr, or is there an automatic fallback to en.po ?
There was a problem hiding this comment.
Product Opener does not use common.pot at all in fact, it reads only the *.po files. The common.pot is used by Crowdin.
In practice, we probably should have only one file, and configure crowdin to use en.po instead of common.pot
@teolemon is the master of the crowdin configuration
There was a problem hiding this comment.
This is related to GNU GetText.
per phrase.com:
POT, short for “portable object template”, is a format generated by GNU gettext to streamline the software localization and internationalization. While source strings are placed after “msgid”, their translations are placed after “msgtr”.
Note: POT files can sometimes be PO files as well. These two files are mostly identical except that PO files are generated by calling “msginit” in CMD. It is possible to perform the translation on a POT file first and then rename it to a PO. The final localized format should be a machine-readable “.mo” file generated from the PO file. The “.mo” file can be generated by calling “msgfmt” in CMD.
In practise, Product Opener does not support .pot or .mo files
There was a problem hiding this comment.
LGTM, just added a comment to @stephanegigandet on a topic I do not master !
|
@yuktea : I added a commit to add translation in Hindi, so that we can check that it is working.
After that you have to run make build_land and make restart, then put the interface in Hindi (using the world-hi.openfoodfacts.localhost domain for instance) |
|
Kudos, SonarCloud Quality Gate passed!
|
Thank you for testing this out, @stephanegigandet ! It's a mystery why it wouldn't work for me despite doing everything right (the exact same changes+ |
Fixes Issue #6332