Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Email address with space #6578

Merged
merged 2 commits into from
Apr 11, 2022
Merged

fix: Email address with space #6578

merged 2 commits into from
Apr 11, 2022

Conversation

aadarsh-ram
Copy link
Contributor

Description

It's possible to create a new user account with an email address that contains spaces.

Related issue(s) and discussion

@aadarsh-ram aadarsh-ram requested a review from a team as a code owner April 9, 2022 15:55
@aadarsh-ram aadarsh-ram mentioned this pull request Apr 9, 2022
Closed
stephanegigandet
stephanegigandet requested changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but we can use the modified email already in $address

@sonarcloud
Copy link

sonarcloud bot commented Apr 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

stephanegigandet
stephanegigandet approved these changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@aadarsh-ram
Copy link
Contributor Author

@stephanegigandet Thank you! Hope to contribute more!

@stephanegigandet stephanegigandet merged commit 7469115 into openfoodfacts:main Apr 11, 2022
@alexgarel alexgarel mentioned this pull request Apr 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanegigandet stephanegigandet stephanegigandet approved these changes

Assignees

@aadarsh-ram aadarsh-ram

Labels
None yet
Projects
old prs
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Email address with space
2 participants
@aadarsh-ram @stephanegigandet