-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ingredients and nutrition should have titles #6839
Conversation
because we made them collapsable. fixes: #6835
I get icons from : https://icon-sets.iconify.design/fa-solid/balance-scale-left/ and https://icon-sets.iconify.design/mdi/bowl-mix/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, we can merge as-is, and then maybe later we can try to make things a bit better when we don't know the ingredients.
Ah, I forgot one thing about icons: we should add them to the /icons directory instead of creating a separate directory for panel icons. |
ef340af
to
676f211
Compare
templates/api/knowledge-panels/health/ingredients/ingredients.tt.json
Outdated
Show resolved
Hide resolved
676f211
to
c744b6c
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
because we made them collapsible.
fixes: #6835