Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: small improvements to ingredients and nutrition table panels #6869

Merged
merged 1 commit into from
Jun 10, 2022
Merged

feat: small improvements to ingredients and nutrition table panels #6869

merged 1 commit into from
Jun 10, 2022

Conversation

stephanegigandet
Copy link
Contributor

Some small changes:

  • made barcode, ingredients and nutrition table icons colorless (removing the fill completely instead of using current color) so that they can be colored more easily
  • made the icon color for the ingredients and nutrition facts knowledge panel dependent on the evaluation, and the evaluation is currently unknown, which makes the icon grey: this should solve the issue that the icons were not visible in Smoothie in dark mode
  • display the Eco-Score not applicable icon in the Eco-Score facet

@stephanegigandet stephanegigandet added icons 📖 Knowledge Panels - https://wiki.openfoodfacts.org/Knowledge_panels labels Jun 8, 2022
@stephanegigandet stephanegigandet requested a review from a team as a code owner June 8, 2022 07:05
@github-actions github-actions bot added Attributes https://wiki.openfoodfacts.org/Product_Attributes Display 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. labels Jun 8, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jun 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

alexgarel
alexgarel approved these changes Jun 10, 2022
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool.

@stephanegigandet stephanegigandet merged commit 154f881 into main Jun 10, 2022
@stephanegigandet stephanegigandet deleted the colorless-icons branch June 10, 2022 15:34
@alexgarel alexgarel mentioned this pull request Jun 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

Assignees

@stephanegigandet stephanegigandet

Labels
Attributes https://wiki.openfoodfacts.org/Product_Attributes Display icons 📖 Knowledge Panels - https://wiki.openfoodfacts.org/Knowledge_panels 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes.
Projects
Product Opener - Sprint
Archived in project
🍊 Open Food Facts Server issues
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephanegigandet @alexgarel