Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: columns synonyms for Packtic import #7099

Merged
merged 1 commit into from
Jul 21, 2022
Merged

fix: columns synonyms for Packtic import #7099

merged 1 commit into from
Jul 21, 2022

Conversation

stephanegigandet
Copy link
Contributor

Recognize some columns automatically in file provided by Packtic

@stephanegigandet stephanegigandet added the 🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers label Jul 20, 2022
@stephanegigandet stephanegigandet requested a review from a team as a code owner July 20, 2022 10:50
@sonarcloud
Copy link

sonarcloud bot commented Jul 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@@ -538,7 +539,7 @@ my %fields_synonyms = (

en => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should'nt we migrate that to a taxonomy at some point ? ;-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at some point, yes :)

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants