Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return statements #7104

Merged
merged 1 commit into from
Jul 21, 2022
Merged

fix: return statements #7104

merged 1 commit into from
Jul 21, 2022

Conversation

dipietroR
Copy link
Contributor

Adding return statements to subroutines without them. There should be no more subroutines without return statements at the moment.

@dipietroR
fix: return statements
08d3ec4 
Adding return statements to subroutines without them
@dipietroR dipietroR requested a review from a team as a code owner July 20, 2022 15:45
@github-actions github-actions bot added Data import Display Food groups Food.pm 🌳 Forest Footprint This is a score designed by a French NGO to assess the deforestation impact (in sq meters) Orgs 📍🏭 Packager codes https://blog.openfoodfacts.org/en/news/discover-what-food-products-are-made-near-you-with-made-near- 📦 Packaging https://wiki.openfoodfacts.org/Category:Recycling 🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers recipes 👥 Users MainCountries labels Jul 20, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jul 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@stephanegigandet stephanegigandet merged commit 6751d3e into main Jul 21, 2022
@stephanegigandet stephanegigandet deleted the return-statements branch July 21, 2022 08:57
alexgarel
alexgarel approved these changes Jul 21, 2022
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thank you @dipietroR

@alexgarel alexgarel mentioned this pull request Jul 21, 2022
Merged
LandonPattison pushed a commit that referenced this pull request Jul 24, 2022
@dipietroR @LandonPattison
fix: return statements (#7104)
9d24caa 
Adding return statements to subroutines without them
LandonPattison pushed a commit that referenced this pull request Jul 25, 2022
@dipietroR @LandonPattison
fix: return statements (#7104)
63dbbf6 
Adding return statements to subroutines without them
LandonPattison pushed a commit that referenced this pull request Jul 25, 2022
@dipietroR @LandonPattison
fix: return statements (#7104)
7b72159 
Adding return statements to subroutines without them
LandonPattison pushed a commit that referenced this pull request Jul 25, 2022
@dipietroR @LandonPattison
fix: return statements (#7104)
2e9e3c8 
Adding return statements to subroutines without them
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

@stephanegigandet stephanegigandet stephanegigandet approved these changes

Assignees

@dipietroR dipietroR

Labels
Data import Display Food groups Food.pm 🌳 Forest Footprint This is a score designed by a French NGO to assess the deforestation impact (in sq meters) MainCountries Orgs 📍🏭 Packager codes https://blog.openfoodfacts.org/en/news/discover-what-food-products-are-made-near-you-with-made-near- 📦 Packaging https://wiki.openfoodfacts.org/Category:Recycling 🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers recipes 👥 Users
Projects
No open projects
Outreachy 2022
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dipietroR @alexgarel @stephanegigandet