Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Connect to Redis for populating search #7239

Merged
merged 12 commits into from
Oct 10, 2022
Merged

feat: Connect to Redis for populating search #7239

merged 12 commits into from
Oct 10, 2022

Conversation

simonj2
Copy link
Contributor

@simonj2 simonj2 commented Aug 23, 2022

What

This PR connects the Server to the search service so that new writes are populated. See the search service here: https://github.com/openfoodfacts/openfoodfacts-search

@simonj2 simonj2 requested a review from a team as a code owner August 23, 2022 03:34
@github-actions github-actions bot added 📚 Documentation Documentation issues improve the project for everyone. GitHub Actions Pull requests that update Github_actions code Products labels Aug 23, 2022
@simonj2 simonj2 changed the title [DO NOT MERGE YET] Connect to Redis feat: [DO NOT MERGE YET] Connect to Redis Aug 23, 2022
@alexgarel alexgarel marked this pull request as draft August 23, 2022 07:44
@alexgarel
Copy link
Member

@simonj2 really good. I put it on "draft" state to be clear it's not yet ready.

@github-actions github-actions bot added the 💥 Merge Conflicts 💥 Merge Conflicts label Sep 9, 2022
@simonj2 simonj2 changed the title feat: [DO NOT MERGE YET] Connect to Redis feat: Connect to Redis for populating search Sep 14, 2022
@simonj2 simonj2 marked this pull request as ready for review September 14, 2022 15:02
@github-actions github-actions bot removed the 💥 Merge Conflicts 💥 Merge Conflicts label Sep 14, 2022
@simonj2
Copy link
Contributor Author

simonj2 commented Sep 19, 2022

@stephanegigandet @teolemon - this is ready for review now :)

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simonj2 thanks a lot for this PR, nice work.

I would just prefer we keep connection, and move it to a specific file (but you may argue against it :-) )

lib/ProductOpener/Products.pm Outdated Show resolved Hide resolved
lib/ProductOpener/Products.pm Outdated Show resolved Hide resolved
lib/ProductOpener/Products.pm Outdated Show resolved Hide resolved
lib/ProductOpener/Redis.pm Outdated Show resolved Hide resolved
@simonj2 simonj2 marked this pull request as draft October 1, 2022 05:58
@simonj2
Copy link
Contributor Author

simonj2 commented Oct 1, 2022

Updating to draft since I'm having some trouble getting this to work, and want to use this as a platform to ask for some 👀

@simonj2 simonj2 marked this pull request as ready for review October 5, 2022 04:27
@simonj2
Copy link
Contributor Author

simonj2 commented Oct 5, 2022

This is ready for review again and passing all manual testing. Thanks for the help @alexgarel + @stephanegigandet

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexgarel
Copy link
Member

Thanks a lot @simonj2 :-)

@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@alexgarel
Copy link
Member

I will merge, but for it to be effective we will have to change deployment CI to add redis parameter, but I'll do it on a separate PR.

@alexgarel alexgarel merged commit 589d975 into main Oct 10, 2022
@alexgarel alexgarel deleted the connect_to_redis branch October 10, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 Documentation Documentation issues improve the project for everyone. GitHub Actions Pull requests that update Github_actions code Products
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants