-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add more actions #7304
feat: Add more actions #7304
Conversation
clarify that some of those sections do not exist on web yet
templates/api/knowledge-panels/environment/origins_of_ingredients.tt.json
Outdated
Show resolved
Hide resolved
templates/api/knowledge-panels/environment/origins_of_ingredients.tt.json
Outdated
Show resolved
Hide resolved
templates/api/knowledge-panels/environment/packaging_recycling.tt.json
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Failed test at tests/unit/templates.t line 42.failed to fetch template: file error - parse error - api/knowledge-panels/health/ingredients/nova.tt.json line 58: unexpected token (=)[% IF product.nova_group_error = 'missing_ingredients' %] |
Is the problem fixed by now |
No, we need to generate new test outputs for the build to go green, and the PR to be mergeable |
{ | ||
"element_type": "action", | ||
"action_element": { | ||
"html": `[% lang("action_add_origins") %]`, | ||
"actions": [ | ||
"add_origins", | ||
] | ||
} | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You broke the json here ;-) (it should be included after "elements")
I'm fixing it.
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Translations for actions forgotten in #7304
What