Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: access knowledge panels via API #7711

Merged
merged 3 commits into from
Nov 17, 2022
Merged

fix: access knowledge panels via API #7711

merged 3 commits into from
Nov 17, 2022

Conversation

stephanegigandet
Copy link
Contributor

@stephanegigandet stephanegigandet requested a review from a team as a code owner November 17, 2022 11:44
@stephanegigandet stephanegigandet changed the title fix: acccess knowledge panels via API fix: access knowledge panels via API Nov 17, 2022
@github-actions github-actions bot added Display 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels 🧪 tests labels Nov 17, 2022
alexgarel
alexgarel approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Nov 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@stephanegigandet stephanegigandet merged commit 03a380e into main Nov 17, 2022
@stephanegigandet stephanegigandet deleted the packagings-api-3 branch November 17, 2022 17:03
@alexgarel alexgarel mentioned this pull request Nov 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

Assignees

@stephanegigandet stephanegigandet

Labels
API v3 Display 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels 🧪 tests
Projects
📖 Knowledge panels
Status: To do
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Knowledge panels crash on .net env (not .org)
3 participants
@stephanegigandet @alexgarel @teolemon