Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Eval parse datetime in producers import to continue if dates strings are broken #7741

Merged
merged 2 commits into from
Nov 22, 2022
Merged

fix: Eval parse datetime in producers import to continue if dates strings are broken #7741

merged 2 commits into from
Nov 22, 2022

Conversation

stephanegigandet
Copy link
Contributor

@stephanegigandet stephanegigandet commented Nov 21, 2022 •
edited by teolemon
Loading

fixes #7739

@stephanegigandet stephanegigandet requested a review from a team as a code owner November 21, 2022 17:58
@github-actions github-actions bot added Data import 🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers labels Nov 21, 2022
@sonarcloud
Copy link

sonarcloud bot commented Nov 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

alexgarel
alexgarel approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexgarel alexgarel merged commit 763ceb8 into main Nov 22, 2022
@alexgarel alexgarel deleted the eval-parse_datetime branch November 22, 2022 08:51
@alexgarel alexgarel mentioned this pull request Nov 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

Assignees

@stephanegigandet stephanegigandet

Labels
Data import 🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers
Projects
🏭 Producers Platform
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Export from producers platform fail for 1 product with empty imported_date field
2 participants
@stephanegigandet @alexgarel